public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
From: William McVicker <willmcvicker@google.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, kernel-team@android.com
Subject: modpost warning by default on missing Module.symvers
Date: Mon, 9 Jan 2023 12:45:40 -0800	[thread overview]
Message-ID: <Y7x89C9nAVX98T4g@google.com> (raw)

Hi Masahiro,

I recently noticed that in commit 4475dff55c54 ("kbuild: fix false-positive
modpost warning when all symbols are trimmed") [1] you modified the modpost
behavior to always warn (by passing `-w`) when there are missing Module.symver
files in order to allow module builds to continue building with warnings
instead of errors. I'm curious why you decided to not continue to rely on
KBUILD_MODPOST_WARN to enable/disable that functionality?

I personally find it useful to keep these types of warnings as errors in order
to catch missing dependencies at build time (ideally by the CI build) instead
of at runtime when a module fails to load due to a missing symbol dependency.

Let me know your thoughts on this and I'll try to come up with a solution to
factor in any concerns you have.

Thanks,
Will

[1] https://lore.kernel.org/all/20210325185412.2352951-3-masahiroy@kernel.org/

             reply	other threads:[~2023-01-09 20:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-09 20:45 William McVicker [this message]
2023-01-10  6:50 ` modpost warning by default on missing Module.symvers Masahiro Yamada
2023-01-10 18:43   ` William McVicker
2023-01-11  5:34     ` Masahiro Yamada
2023-01-17 21:51       ` William McVicker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y7x89C9nAVX98T4g@google.com \
    --to=willmcvicker@google.com \
    --cc=kernel-team@android.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox