Re: [PATCH 03/17] Makefile: generate `CLANG_FLAGS` even in GCC builds

Miguel Ojeda
2021-07-14T20:31:16Z

On Wed, Jul 14, 2021 at 8:14 PM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> Patch LGTM; please keep an eye on the series:
> https://lore.kernel.org/lkml/20210707224310.1403944-2-ndesaulniers@google.com/
>
> If that lands in kbuild before this, this patch will need to be
> rebased to avoid a conflict in linux-next.
>
> So (tentatively :-P):
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>

Thanks for the heads up!

Given how fast `rustc_codegen_gcc` is progressing, we may need to
prioritize getting
https://github.com/rust-lang/rust-bindgen/issues/1949 fixed so that we
can drop this hack altogether and go for proper, full GCC support.

> If the patch needs to be rebased on the series linked above, please
> drop my reviewed by tag and I will re-review. Perhaps putting me
> explicitly on Cc: in the commit message will help notify me if there
> are successive versions?

Ack -- will do that.

Cheers,
Miguel