Re: [PATCH 1/2] gcc-plugins: Explicitly document purpose and deprecation schedule

Kees Cook
2021-10-20T19:12:49Z

On Wed, Oct 20, 2021 at 07:44:19PM +0200, Miguel Ojeda wrote:
> On Wed, Oct 20, 2021 at 7:35 PM Kees Cook <keescook@chromium.org> wrote:
> >
> > +Purpose
> > +=======
>
> Sounds good to me.
>
> > config GCC_PLUGIN_SANCOV
> > bool
> > + # Plugin can be removed once the kernel only supports GCC 6.1.0+
>
> Since we are just giving the major in the other cases below, I would
> just say GCC 6+ here (the numbering scheme changed in GCC 5 already).

Sure; now updated.

> Thanks for adding the versions, by the way -- this is useful long-term
> and not always done for other things...

Yeah, I always struggled to find when options were added to GCC, so I
wanted this for my poor brain too. :)

> Reviewed-by: Miguel Ojeda <ojeda@kernel.org>

Thanks!

--
Kees Cook