Re: [PATCH v8 08/14] livepatch: only match unique symbols when using FG-KASLR

Alexander Lobakin
2021-12-03T14:15:06Z

From: Peter Zijlstra <peterz@infradead.org>
Date: Fri, 3 Dec 2021 11:05:54 +0100

> On Thu, Dec 02, 2021 at 11:32:08PM +0100, Alexander Lobakin wrote:
> > If any type of function granular randomization is enabled, the sympos
> > algorithm will fail, as it will be impossible to resolve symbols when
> > there are duplicates using the previous symbol position.
> >
> > We could override sympos to 0, but make it more clear to the user
> > and bail out if the symbol is not unique.
>
> Since we're going lots of horrendous things already, why can't we fix
> this duplicate nonsense too?

Oh, I see a ton of code duplication here in Kristen's code as well.
I'll address it.

Al