Re: [PATCH v8 07/14] kallsyms: Hide layout

Josh Poimboeuf
2021-12-07T05:31:52Z

On Fri, Dec 03, 2021 at 11:03:35AM +0100, Ard Biesheuvel wrote:
> On Fri, 3 Dec 2021 at 11:01, Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > On Thu, Dec 02, 2021 at 11:32:07PM +0100, Alexander Lobakin wrote:
> > > From: Kristen Carlson Accardi <kristen@linux.intel.com>
> > >
> > > This patch makes /proc/kallsyms display in a random order, rather
> > > than sorted by address in order to hide the newly randomized address
> > > layout.
> >
> > Is there a reason to not always do this? That is, why are we keeping two
> > copies of this code around? Less code is more better etc..
>
> +1.
>
> IIRC I made the exact same point when this patch was sent out by
> Kristen a while ago.

Yes. Alexander, I'd recommend going back to the review comments from
Kristen's last posting, they may have been missed.

--
Josh