From: Andrew Lunn <andrew@lunn.ch>
To: Yinbo Zhu <zhuyinbo@loongson.cn>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH v4 1/2] modpost: file2alias: make mdio alias configure match mdio uevent
Date: Sat, 4 Dec 2021 16:11:54 +0100 [thread overview]
Message-ID: <YauFOgy6tjH+kf3J@lunn.ch> (raw)
In-Reply-To: <1638609208-10339-1-git-send-email-zhuyinbo@loongson.cn>
On Sat, Dec 04, 2021 at 05:13:27PM +0800, Yinbo Zhu wrote:
> The do_mdio_entry was responsible for generating a phy alias configure
> that according to the phy driver's mdio_device_id, before apply this
> patch, which alias configure is like "alias mdio:000000010100000100001
> 1011101????", it doesn't match the phy_id of mdio_uevent, because of
> the phy_id was a hexadecimal digit and the mido uevent is consisit of
> phy_id with the char 'p', the uevent string is different from alias.
> Add this patch that mdio alias configure will can match mdio uevent.
>
> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
> ---
> Change in v4:
> Add following explain information.
Adding an explanation will not stop the regression happening. You will
continue to get a NACK while your change causes a regression. Please
do not post again until you have addressed the regression.
Andrew
prev parent reply other threads:[~2021-12-04 15:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 9:13 [PATCH v4 1/2] modpost: file2alias: make mdio alias configure match mdio uevent Yinbo Zhu
2021-12-04 9:13 ` [PATCH v4 2/2] net: mdio: rework mdio_uevent for mdio ethernet phy device Yinbo Zhu
2021-12-04 9:38 ` Russell King (Oracle)
2021-12-04 9:38 ` [PATCH v4 1/2] modpost: file2alias: make mdio alias configure match mdio uevent Russell King (Oracle)
2021-12-04 15:11 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YauFOgy6tjH+kf3J@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox