From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC0CDC433F5 for ; Fri, 25 Mar 2022 20:00:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231828AbiCYUBx (ORCPT ); Fri, 25 Mar 2022 16:01:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231699AbiCYUBg (ORCPT ); Fri, 25 Mar 2022 16:01:36 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D126F237FC3; Fri, 25 Mar 2022 12:51:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648237911; x=1679773911; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=lrl+aGeTbvJwiVMu8xaP539HJmgEuuOyUPsz3gqZvvs=; b=JM57FRYiBGcwfvjgQFuXwPsE0kYLEryANF2Xq0lZB+3G1QkHV/YgCM8Z lHR2ia1fhKl9A05IkVJ8oXJK9wfSbvr5jrJOYIWZIfxhUuGwAI8lxRgzQ 4v+2A4yeyD/FTLdPW3VwOWXgJZD/+w88XXjpXlPgQnsCjM1CKJDMasGJE DiOkHcRSOFrtXSSITlBUFkDrrO9EFnyl0AGbNxG4YIIE5uU8Mav/60ePE myzqb8uV0xbwJdgaZ6AWrnZ4L+evgguBUVTup/mfH8P5rHp9EwJCoCT/a hJ0l6RML67Ao+btb5o7BSImXPcD9rqeAC1Bxr3S/bGxu2PQeoEVMcy6Zc A==; X-IronPort-AV: E=McAfee;i="6200,9189,10297"; a="256261523" X-IronPort-AV: E=Sophos;i="5.90,211,1643702400"; d="scan'208";a="256261523" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2022 10:52:33 -0700 X-IronPort-AV: E=Sophos;i="5.90,211,1643702400"; d="scan'208";a="602123064" Received: from smile.fi.intel.com ([10.237.72.59]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2022 10:52:31 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nXo6N-006Wfs-Po; Fri, 25 Mar 2022 19:51:55 +0200 Date: Fri, 25 Mar 2022 19:51:55 +0200 From: Andy Shevchenko To: Linus Torvalds Cc: Linux Kbuild mailing list , Linux Kernel Mailing List , Masahiro Yamada , Michal Marek , Nick Desaulniers , Borislav Petkov , Ingo Molnar , Peter Zijlstra Subject: Re: [PATCH v1 1/1] Makefile.extrawarn: Turn off -Werror when extra warnings are enabled Message-ID: References: <20220325131348.3995-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org On Fri, Mar 25, 2022 at 10:18:06AM -0700, Linus Torvalds wrote: > On Fri, Mar 25, 2022 at 6:13 AM Andy Shevchenko > wrote: > > > > +# > > +# Turn off -Werror when extra warnings are enabled > > +# > > +ifneq ($(KBUILD_EXTRA_WARN),) > > + KBUILD_CFLAGS += -Wno-error > > +endif > > NAK. > > If you enabled CONFIG_WERROR, then you get CONFIG_WERROR. > > If you enabled W=1, then you get extra warnings. > > If you enabled both, then you get extra warnings and they are errors. > > This patch is just stupid. Fair enough. -- With Best Regards, Andy Shevchenko