From: Luis Chamberlain <mcgrof@kernel.org>
To: Ole Schuerks <ole0811sch@gmail.com>
Cc: deltaone@debian.org, jan.sollmann@rub.de, jude.gyimah@rub.de,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
masahiroy@kernel.org, nathan@kernel.org, nicolas@fjasle.eu,
thorsten.berger@rub.de
Subject: Re: [PATCH v6 01/11] kconfig: Add PicoSAT interface
Date: Tue, 10 Dec 2024 19:48:01 -0800 [thread overview]
Message-ID: <Z1kLcQmBKC4bzm73@bombadil.infradead.org> (raw)
In-Reply-To: <20241209005713.52352-1-ole0811sch@gmail.com>
On Mon, Dec 09, 2024 at 01:57:13AM +0100, Ole Schuerks wrote:
> Thanks for all the feedback.
>
> > This just deals with the first error and there is no unwinding, is that OK?
>
> This should be OK. dlsym() only retrieves the address of a symbol from an
> already loaded object. The calls to dlsym() thus should not need to be
> unwound, it's sufficient to unload the object via dlclose().
OK thanks, maybe add a comment about it.
> > Other than that, did you run this through checkpatch.pl?
>
> I ran all patches through checkpath.pl. The only reported issues with this
> patch are the ones related to the use of the X-macro and one about the
> typedef for the PicoSAT type.
I don't know what x-macro is so I don't have any clear opinion on that.
Luis
next prev parent reply other threads:[~2024-12-11 3:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 3:49 [PATCH v6 00/11] kbuild, kconfig: Add support for conflict resolution Ole Schuerks
2024-10-28 3:49 ` [PATCH v6 01/11] kconfig: Add PicoSAT interface Ole Schuerks
2024-12-04 23:07 ` Luis Chamberlain
2024-12-09 0:57 ` Ole Schuerks
2024-12-11 3:48 ` Luis Chamberlain [this message]
2024-10-28 3:49 ` [PATCH v6 02/11] kbuild: Add list_size, list_at_index, list_for_each_from Ole Schuerks
2024-12-04 23:19 ` Luis Chamberlain
2024-12-09 1:00 ` Ole Schuerks
2024-12-11 3:49 ` Luis Chamberlain
2024-10-28 3:49 ` [PATCH v6 03/11] kconfig: Add definitions Ole Schuerks
2024-10-28 3:49 ` [PATCH v6 04/11] kconfig: Add files for building constraints Ole Schuerks
2024-10-28 3:49 ` [PATCH v6 05/11] kconfig: Add files for handling expressions Ole Schuerks
2024-10-28 3:49 ` [PATCH v6 06/11] kconfig: Add files for RangeFix Ole Schuerks
2024-12-04 23:23 ` Luis Chamberlain
2024-10-28 3:49 ` [PATCH v6 07/11] kconfig: Add files with utility functions Ole Schuerks
2024-10-28 3:49 ` [PATCH v6 08/11] kconfig: Add tools Ole Schuerks
2024-10-28 3:49 ` [PATCH v6 09/11] kconfig: Add xconfig-modifications Ole Schuerks
2024-10-28 3:49 ` [PATCH v6 10/11] kconfig: Add loader.gif Ole Schuerks
2024-10-28 3:49 ` [PATCH v6 11/11] kconfig: Add documentation for the conflict resolver Ole Schuerks
2024-12-04 22:58 ` [PATCH v6 00/11] kbuild, kconfig: Add support for conflict resolution Luis Chamberlain
2024-12-04 23:26 ` Luis Chamberlain
2025-01-09 13:28 ` [PATCH v6 01/11] kconfig: Add PicoSAT interface Brendan Jackman
2025-01-10 19:15 ` Luis Chamberlain
2025-01-13 16:29 ` Brendan Jackman
2025-02-07 15:43 ` Thorsten Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1kLcQmBKC4bzm73@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=deltaone@debian.org \
--cc=jan.sollmann@rub.de \
--cc=jude.gyimah@rub.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=ole0811sch@gmail.com \
--cc=thorsten.berger@rub.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox