From: Nicolas Schier <nicolas@fjasle.eu>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Nathan Chancellor <nathan@kernel.org>
Subject: Re: [PATCH] modpost: introduce get_basename() helper
Date: Sat, 8 Feb 2025 10:31:31 +0100 [thread overview]
Message-ID: <Z6ckc-O_i-qtwvb1@bergen> (raw)
In-Reply-To: <20250207175024.412054-1-masahiroy@kernel.org>
On Sat 08 Feb 2025 02:50:13 GMT, Masahiro Yamada wrote:
> The logic to retrieve the basename appears multiple times.
> Factor out the common pattern into a helper function.
>
> I copied kbasename() from include/linux/string.h and renamed it
> to get_basename().
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> scripts/mod/modpost.c | 41 ++++++++++++++++++----------------------
> scripts/mod/modpost.h | 1 +
> scripts/mod/sumversion.c | 13 ++++---------
> 3 files changed, 23 insertions(+), 32 deletions(-)
Thanks.
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
prev parent reply other threads:[~2025-02-08 9:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 17:50 [PATCH] modpost: introduce get_basename() helper Masahiro Yamada
2025-02-08 9:31 ` Nicolas Schier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6ckc-O_i-qtwvb1@bergen \
--to=nicolas@fjasle.eu \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox