From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from e2i673.smtp2go.com (e2i673.smtp2go.com [103.2.142.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9679C1EDA37 for ; Tue, 11 Feb 2025 07:37:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.2.142.161 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739259455; cv=none; b=F0uX5Gi/LRhNglA/8y3dZGfBqg+2oyvmIfwyij0U0YYigIzOseQ/gpRCYfJ2mVj8qKt9Eey3CSNILhixwMjC+TVOBFdcAP5NJ0zk8yentUOh3fLfZjRJpuiNmfKzbjFwPxFJl5d2hAaR36d+e70nyrwgKprK/V3qhS1keiYHM7g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739259455; c=relaxed/simple; bh=QWC9deTNsC1GcDXhXNZCOENwee7u715bsmzbXt2Hfqc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=P0mj83s3IFPjcL4qzcSa2/sCAYlTCcD8McDr6OVj+viUuO6UIweFFLCMBsukdm0pDj8Zl4q+xvnZSU3Nh//JvwbS+tVBlsHpQVqCFHgquIbwjhGiAWaiLgHHIM2ODiUioZYjAZhmpjBnw3QbWempZ+SIsCMpFpXMTbJTAgOYh6s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fjasle.eu; spf=pass smtp.mailfrom=em1174286.fjasle.eu; dkim=fail (0-bit key) header.d=smtpservice.net header.i=@smtpservice.net header.b=YIBR7rc4 reason="unknown key version"; dkim=pass (2048-bit key) header.d=fjasle.eu header.i=@fjasle.eu header.b=SJNHPC6L; dkim=pass (1024-bit key) header.d=fjasle.eu header.i=@fjasle.eu header.b=VlRO2wcA; arc=none smtp.client-ip=103.2.142.161 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fjasle.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=em1174286.fjasle.eu Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="unknown key version" (0-bit key) header.d=smtpservice.net header.i=@smtpservice.net header.b="YIBR7rc4"; dkim=pass (2048-bit key) header.d=fjasle.eu header.i=@fjasle.eu header.b="SJNHPC6L"; dkim=pass (1024-bit key) header.d=fjasle.eu header.i=@fjasle.eu header.b="VlRO2wcA" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=smtpservice.net; s=mp6320.a1-4.dyn; x=1739260346; h=Feedback-ID: X-Smtpcorp-Track:Message-ID:Subject:To:From:Date:Reply-To:Sender: List-Unsubscribe:List-Unsubscribe-Post; bh=OWjrhNaZdQZFGwxKdiBQQCI7wGCOzVV0Oh7tcBp8qG0=; b=YIBR7rc4co81p4+cdrmELeLbsQ 71VYUCgJBssRTHsxjJXLOFPYEgWKaw7y/OLq5GyfzJMfnedYwMNc43wtQRMgOHdQwzTrneUZp9Wlq oXqiHDYB4XelXdtLopugw6BHV2fWQMsPdspotavsOiyY/TPoeZSXDol1Ler45dAJIfOvE6tR0D0Nm Limk9BXddiBEmZK5NGbZoqefVRqNjLXEmOsBXGFXywMyLPptNsc3J/BK5LoPU6DokdYLzf9yV/B6A +O0HidpXDzAGpHFt0eNGJ4TPMKSwkxPMUA3Qanoh5Urz/+4HKLKnC/s04eB6lG+p58rCYg18OCvew 9q3erhOA==; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fjasle.eu; i=@fjasle.eu; q=dns/txt; s=s1174286; t=1739259446; h=from : subject : to : message-id : date; bh=OWjrhNaZdQZFGwxKdiBQQCI7wGCOzVV0Oh7tcBp8qG0=; b=SJNHPC6L6dys02PdrOVn5xphCc9Ocg7e9qh3gYDdLog1PumGENWVUQrNjZPpm5CHV6bTE +0eo2MF1zLyZDqai23rnGTRwYvxeItkUVjWftDCsP78KgQUINkRjOH4BT5bKwcA7Bk2nqOy soHLKMGp130sEu96LxNldCNOlKlna5hDtNJMawvSP9izHcexZuQqSz/QhDX7wVDZSyY1+3o D2ELfWdrWo4TQS2cgCxdaz0CfNUaFt/sQXFZtz1EeqNZt00fXAZvkSgUTWoxyhdqG7kve4A B3CDyXiodkOLI2ad1r2stxr+jTZGyHb88rx0OIz2CQIAw3Fz+Ncv3jZjF3Ow== Received: from [10.172.233.58] (helo=SmtpCorp) by smtpcorp.com with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2-S2G) (envelope-from ) id 1thkms-qt4IZt-JO; Tue, 11 Feb 2025 07:34:30 +0000 Received: from [10.85.249.164] (helo=leknes.fjasle.eu) by smtpcorp.com with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.97.1-S2G) (envelope-from ) id 1thkmr-FnQW0hPoGyp-mM8o; Tue, 11 Feb 2025 07:34:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fjasle.eu; s=mail; t=1739259268; bh=QWC9deTNsC1GcDXhXNZCOENwee7u715bsmzbXt2Hfqc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VlRO2wcAX+e9SaIF3Z1vX6aOv5XRh24Yg7SutsGe6s3Pspf0Jl/hzcKHphsnrpm8l Y45vTxY4vX6cy1hpmnzfjKne/W7Xe/Zyx4+o7inTRCwMvdCB02uZjxrOTAzp0IKOdI asX6SMdzYJmQZkzUuFFJobysOGP1T1jNeQcqnBgI= Received: by leknes.fjasle.eu (Postfix, from userid 1000) id 0F4D4495A6; Tue, 11 Feb 2025 08:34:28 +0100 (CET) Date: Tue, 11 Feb 2025 08:34:27 +0100 From: Nicolas Schier To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Nathan Chancellor Subject: Re: [PATCH] modpost: use strstarts() to clean up parse_source_files() Message-ID: References: <20250207175104.412158-1-masahiroy@kernel.org> Precedence: bulk X-Mailing-List: linux-kbuild@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Smtpcorp-Track: fdCGFlWrrn-4.emrcpIodG0Bo.AWsYNQ6MumV Feedback-ID: 1174286m:1174286a9YXZ7r:1174286snGC8PquRF X-Report-Abuse: Please forward a copy of this message, including all headers, to On Tue, Feb 11, 2025 at 09:43:05AM +0900 Masahiro Yamada wrote: > On Sat, Feb 8, 2025 at 6:38 PM Nicolas Schier wrote: > > > > On Sat 08 Feb 2025 02:50:55 GMT, Masahiro Yamada wrote: > > > No functional changes are intended. > > > > > > Signed-off-by: Masahiro Yamada > > > --- > > > > > > scripts/mod/sumversion.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/scripts/mod/sumversion.c b/scripts/mod/sumversion.c > > > index e79fc40d852f..3dd28b4d0099 100644 > > > --- a/scripts/mod/sumversion.c > > > +++ b/scripts/mod/sumversion.c > > > @@ -330,7 +330,7 @@ static int parse_source_files(const char *objfile, struct md4_ctx *md) > > > line++; > > > p = line; > > > > > > - if (strncmp(line, "source_", sizeof("source_")-1) == 0) { > > > + if (strstarts(line, "source_")) { > > > p = strrchr(line, ' '); > > > if (!p) { > > > warn("malformed line: %s\n", line); > > > @@ -344,7 +344,7 @@ static int parse_source_files(const char *objfile, struct md4_ctx *md) > > > } > > > continue; > > > } > > > - if (strncmp(line, "deps_", sizeof("deps_")-1) == 0) { > > > + if (strstarts(line, "deps_")) { > > > check_files = 1; > > > continue; > > > } > > > -- > > > 2.43.0 > > > > > > > Thanks, looks good to me. > > > > Reviewed-by: Nicolas Schier > > > > Do you also want to replace the last strncmp() in > > scripts/mod/modpost.c? > > > > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c > > index e18ae7dc8140..31468923cdf6 100644 > > --- a/scripts/mod/modpost.c > > +++ b/scripts/mod/modpost.c > > @@ -670,7 +670,7 @@ static char *get_next_modinfo(struct elf_info *info, const char *tag, > > } > > > > for (p = modinfo; p; p = next_string(p, &size)) { > > - if (strncmp(p, tag, taglen) == 0 && p[taglen] == '=') > > + if (strstarts(p, tag) == 0 && p[taglen] == '=') > > return p + taglen + 1; > > } > > return NULL; > > > I believe you meant: > > if (strstarts(p, tag) && p[taglen] == '=') ups, yes. > I do not think there is a strong reason to do so > because taglen is already calculated a few lines above, > but the compiler may be clever enough to avoid > calling strlen() twice. I did not check the compiler output. yeah, I was thinking about code (style) consistency, but you're right, it would not be beneficial. Kind regards, Nicolas