From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Xi Ruoyao <xry111@xry111.site>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Matt Redfearn <matt.redfearn@blaize.com>,
linux-mips@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: Ignore relocs against __ex_table for relocatable kernel
Date: Wed, 26 Feb 2025 19:10:23 +0100 [thread overview]
Message-ID: <Z79ZD3EL1Q8UjaFH@alpha.franken.de> (raw)
In-Reply-To: <20250226104340.3f0b961b@gandalf.local.home>
On Wed, Feb 26, 2025 at 10:43:40AM -0500, Steven Rostedt wrote:
> On Wed, 26 Feb 2025 21:28:41 +0800
> Xi Ruoyao <xry111@xry111.site> wrote:
>
> > Since commit 6f2c2f93a190 ("scripts/sorttable: Remove unneeded
> > Elf_Rel"), sorttable no longer clears relocs against __ex_table,
> > claiming "it was never used." But in fact MIPS relocatable kernel had
> > been implicitly depending on this behavior, so after this commit the
> > MIPS relocatable kernel has started to spit oops like:
>
> Oops!
>
> >
> > CPU 1 Unable to handle kernel paging request at virtual address 000000fffbbdbff8, epc == ffffffff818f9a6c, ra == ffffffff813ad7d0
> > ... ...
> > Call Trace:
> > [<ffffffff818f9a6c>] __raw_copy_from_user+0x48/0x2fc
> > [<ffffffff813ad7d0>] cp_statx+0x1a0/0x1e0
> > [<ffffffff813ae528>] do_statx_fd+0xa8/0x118
> > [<ffffffff813ae670>] sys_statx+0xd8/0xf8
> > [<ffffffff81156cc8>] syscall_common+0x34/0x58
> >
> > So ignore those relocs on our own to fix the issue.
> >
> > Fixes: 6f2c2f93a190 ("scripts/sorttable: Remove unneeded Elf_Rel")
> > Signed-off-by: Xi Ruoyao <xry111@xry111.site>
>
> Thanks! Yeah, this is better than having an implicit dependency to the
> sorttable code.
>
> I take it that this will go through the mips tree?
yes, I'll take it.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2025-02-26 19:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 13:28 [PATCH] MIPS: Ignore relocs against __ex_table for relocatable kernel Xi Ruoyao
2025-02-26 15:43 ` Steven Rostedt
2025-02-26 18:10 ` Thomas Bogendoerfer [this message]
2025-02-27 10:12 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z79ZD3EL1Q8UjaFH@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=matt.redfearn@blaize.com \
--cc=rostedt@goodmis.org \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox