Re: [PATCH v6 07/12] kbuild: deb-pkg: switch over to source format 3.0 (quilt)

Masahiro Yamada
2023-02-25T08:55:22Z

On Sat, Feb 25, 2023 at 7:48 AM Nicolas Schier <nicolas@fjasle.eu> wrote:

>
> bike-shedding:
>
> cat <<-eof
> Subject: Add .config
> Author: ${maintainer}
>
> --- /dev/null
> +++ linux/.config
> eof

I agree this is more readable, but I used echo to
avoid a process fork.

'echo' is a shell built-in for bash and dash but 'cat' is not.

So, this is a trade-off between readability vs
one less process fork.

If the code were much longer, I would prefer 'cat'.

>
> > + diff -u /dev/null "${KCONFIG_CONFIG}" | tail -n +3
> > +} > debian/patches/config
> > +echo config > debian/patches/series
> >
> > echo $debarch > debian/arch
> > extra_build_depends=", $(if_enabled_echo CONFIG_UNWINDER_ORC libelf-dev:native)"
> > --
> > 2.34.1
>
> Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>

--
Best Regards
Masahiro Yamada