Re: [PATCH v6 12/12] kbuild: add srcdeb-pkg target

Nicolas Schier
2023-03-01T20:47:27Z

[-- Attachment #1: Type: text/plain, Size: 1876 bytes --]

On Sat 25 Feb 2023 19:14:30 GMT, Masahiro Yamada wrote:
>
> On Sat, Feb 25, 2023 at 7:48 AM Nicolas Schier <nicolas@fjasle.eu> wrote:
> >
> > On Wed, Feb 15, 2023 at 10:20:34AM +0900 Masahiro Yamada wrote:
> > > This new target builds only the debian source package.
> > >
> > > Factor similar code out to the 'build-deb-pkg' variable.
> > >
> > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > > ---
[...]
> >
> > While testing, I stumbled over one thing, not really related to this patch:
> >
> > As tar complains about any kind of tree changes while it creates an archive,
> > 'olddefconfig' and 'srcdeb-pkg' must not be build at the same time. Is it
> > sensible to add another 'mixed-build' check in top-level Makefile against all
> > target depending on linux.tar.gz?
> >
> > $ make olddefconfig srcdeb-pkg -j8
>
> This is already done.
>
> The mixture of config targets and non-config targets
> are treated as mixed-build. [1]
> So, Kbuild internally divides it into 'make olddefconfig -j8'
> followed by 'make srcdeb-pkg -j8'.

oh yes, and already for quite some time. I didn't check carefully
enough.

>
> [1] https://github.com/torvalds/linux/blob/v6.2/Makefile#L335
>
>
>
>
>
> > #
> > # No change to .config
> > #
> > GEN debian
> > UPD .tmp_filelist
> > TAR linux.tar.gz
> > tar: .: file changed as we read it
> > make[2]: *** [scripts/Makefile.package:58: linux.tar.gz] Error 1
> > make[2]: *** Deleting file 'linux.tar.gz'
> > make[1]: *** [Makefile:1654: srcdeb-pkg] Error 2
> > make: *** [Makefile:358: __build_one_by_one] Error 2
>
>
> I ran the same command, but I could not reproduce this.

I cannot reproduce it any more; I don't know what might had been the
problem on my site.

Kind regards,
Nicolas

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]