From: Lukas Hruska <lhruska@suse.cz>
To: Petr Mladek <pmladek@suse.com>, Miroslav Benes <mbenes@suse.cz>,
Josh Poimboeuf <jpoimboe@kernel.org>
Cc: Joe Lawrence <joe.lawrence@redhat.com>,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org,
Marcos Paulo de Souza <mpdesouza@suse.com>,
Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: [PATCH v1 3/5] kbuild/modpost: integrate klp-convert
Date: Thu, 25 Jan 2024 10:44:40 +0100 [thread overview]
Message-ID: <ZbItbbsYrKdWT_Ma@dhcp182.suse.cz> (raw)
In-Reply-To: <20231106162513.17556-4-lhruska@suse.cz>
There is also a typo in Makefile which causes a modules.livepatch file
to be created in kernel sources even in case of building an external
module.
> diff --git a/Makefile b/Makefile
> index 2fdd8b40b7e0..459b9c9fe0a8 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1185,6 +1185,7 @@ PHONY += prepare0
> export extmod_prefix = $(if $(KBUILD_EXTMOD),$(KBUILD_EXTMOD)/)
> export MODORDER := $(extmod_prefix)modules.order
> export MODULES_NSDEPS := $(extmod_prefix)modules.nsdeps
> +export MODULES_LIVEPATCH := $(extmod-prefix)modules.livepatch
This should be `$(extmod_prefix)`.
Best Regards,
Lukas
next prev parent reply other threads:[~2024-01-25 9:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 16:25 [PATCH v1 0/5] livepatch: klp-convert tool - Minimal version Lukas Hruska
2023-11-06 16:25 ` [PATCH v1 1/5] livepatch: Create and include UAPI headers Lukas Hruska
2024-01-05 10:15 ` Petr Mladek
2024-01-10 13:38 ` Marcos Paulo de Souza
2023-11-06 16:25 ` [PATCH v1 2/5] livepatch: Add klp-convert tool Lukas Hruska
2024-01-05 13:29 ` Petr Mladek
2024-01-10 19:03 ` Marcos Paulo de Souza
2024-01-05 15:01 ` Petr Mladek
2023-11-06 16:25 ` [PATCH v1 3/5] kbuild/modpost: integrate klp-convert Lukas Hruska
2024-01-05 14:03 ` Petr Mladek
2024-01-10 19:37 ` Marcos Paulo de Souza
2024-01-25 9:44 ` Lukas Hruska [this message]
2023-11-06 16:25 ` [PATCH v1 4/5] livepatch: Add sample livepatch module Lukas Hruska
2024-01-05 14:14 ` Petr Mladek
2023-11-06 16:25 ` [PATCH v1 5/5] documentation: Update on livepatch elf format Lukas Hruska
2024-01-05 14:16 ` Petr Mladek
2024-01-10 19:54 ` Marcos Paulo de Souza
2024-04-10 15:32 ` [PATCH v1 0/5] livepatch: klp-convert tool - Minimal version Marcos Paulo de Souza
2024-04-11 6:27 ` Miroslav Benes
2024-04-11 13:58 ` Lukas Hruska
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbItbbsYrKdWT_Ma@dhcp182.suse.cz \
--to=lhruska@suse.cz \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mpdesouza@suse.com \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox