From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from e2i652.smtp2go.com (e2i652.smtp2go.com [103.2.142.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B63E137909 for ; Wed, 6 Mar 2024 18:43:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.2.142.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709750605; cv=none; b=mjRqgtWyH8KVIBkmsTwgO2lahlrckmKrGLc6mBILPNZGkEF6PuWG1/6ulOvxrc359f7SWSJFPAIzwFweTGjm3mq4P/2zIUlz7baim2Kaf0KhLTnSKL9tTGNcmYwrpUS3qyoxtV4EW/4JAnsnS6j5gHrl/KNLqarQobkJBok9QLc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709750605; c=relaxed/simple; bh=lqf5F5/wynUuLQMyXci5UgqCurfaGt/bCOCumtuezvc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k9ogiJn+PS6h6McRm7cY2gJz+5Fsy7u9y0SRCf6yz5toJBJVtwA7ij+fOH7LF1lCWsISJKP6JcIpOC06e/ZKutKIEh/nRNiAPc9VeYFeYAne285kSSPkmUOh8hhb/Dm4p0VNkwlgwQQUfpOv0GfBjro7lgkVTMRjw03uYvFjQMw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fjasle.eu; spf=pass smtp.mailfrom=em1174286.fjasle.eu; dkim=fail (0-bit key) header.d=smtpservice.net header.i=@smtpservice.net header.b=lHwQYYjc reason="unknown key version"; dkim=pass (2048-bit key) header.d=fjasle.eu header.i=@fjasle.eu header.b=RX4aSVqE; dkim=pass (1024-bit key) header.d=fjasle.eu header.i=@fjasle.eu header.b=NuqjY41F; arc=none smtp.client-ip=103.2.142.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fjasle.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=em1174286.fjasle.eu Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="unknown key version" (0-bit key) header.d=smtpservice.net header.i=@smtpservice.net header.b="lHwQYYjc"; dkim=pass (2048-bit key) header.d=fjasle.eu header.i=@fjasle.eu header.b="RX4aSVqE"; dkim=pass (1024-bit key) header.d=fjasle.eu header.i=@fjasle.eu header.b="NuqjY41F" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=smtpservice.net; s=mp6320.a1-4.dyn; x=1709751488; h=Feedback-ID: X-Smtpcorp-Track:Message-ID:Subject:To:From:Date:Reply-To:Sender: List-Unsubscribe; bh=lqf5F5/wynUuLQMyXci5UgqCurfaGt/bCOCumtuezvc=; b=lHwQYYjc XUDwlhv6WETSsLwVPgYB2SW9Icg86l2THhFsrLKS1lG6qT54iN17AoySwtdDk6V6nRFr3ZGBHU1sr Lza06CEZ8XbCvyxTCenvgAhxkKIUo5IG6wd+S9mRYwV7rXavd1gXehNru2aBsUG4fOCkragiXYWf4 NhItGGTE9mlY1L9XUlyq0kIB1plbmxy2Wxc3ICPltgEVdZByI1CDHRIz/j8L+q564aveDyoZAd5fW /PNWql0dUzeaLQepdS/lZBdZT7SBAPuFqhsg1IC3YksDeLpexhlGYcTPQm5G+Y7mo57/a5BKzrdEj 3t0sjrxbKNFlTKTTPmL4kXRXWg==; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fjasle.eu; i=@fjasle.eu; q=dns/txt; s=s1174286; t=1709750588; h=from : subject : to : message-id : date; bh=lqf5F5/wynUuLQMyXci5UgqCurfaGt/bCOCumtuezvc=; b=RX4aSVqEjucSea+Eh9KYB4YQEAhiH4xJE7+FbSvZrjfbPe0YnCef8yqwscGrg4kkrlTkH sJ2E59XMdQBJIueCE8JL7aPo06FF9JVUD5nu/2K6foXmzoOPOzBPzxbbBCDxIyZhHUF56LN sI2yhiQAhGFquK7A6rXVqhPyDGbyERpu4pSvC1luk8A05LdCE7Vj9OwXalnbzyKWhBHCZNt FTro8CDuBderecc8D1Mv98ACarbFS2VQSXuI7nWzZsoC7KOYn3ycO4Igdh5VdZZlNt7SrcO r5c4NjxemglWY5rqbtTyOWDTG20qr09PTmHz1TC4guY3bc0d6CZBCJjhBcDQ== Received: from [10.139.162.187] (helo=SmtpCorp) by smtpcorp.com with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2-S2G) (envelope-from ) id 1rhwEA-qt4Bqe-MD; Wed, 06 Mar 2024 18:42:54 +0000 Received: from [10.85.249.164] (helo=leknes.fjasle.eu) by smtpcorp.com with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96.1-S2G) (envelope-from ) id 1rhwEA-4XqxWs-0M; Wed, 06 Mar 2024 18:42:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fjasle.eu; s=mail; t=1709750568; bh=lqf5F5/wynUuLQMyXci5UgqCurfaGt/bCOCumtuezvc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NuqjY41FDI9SwfMB+XzOfXEdDX0enZGk62Jg5uU4RsZTkqUAV4ctou70R32bmz7rB lvhK7kECnrGI/CfyB40ReKlq/LJJhJhbhgJexqPBqI+BFBtoHWPBmh3/chnh+KfbEQ CDtLm2modjfUgR/5SYNdpNH4O0rCkilLrr/UfzJc= Received: by leknes.fjasle.eu (Postfix, from userid 1000) id D3B3E3C401; Wed, 6 Mar 2024 19:42:47 +0100 (CET) Date: Wed, 6 Mar 2024 19:42:47 +0100 From: Nicolas Schier To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kbuild: unexport abs_srctree and abs_objtree Message-ID: References: <20240306104222.308473-1-masahiroy@kernel.org> Precedence: bulk X-Mailing-List: linux-kbuild@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QvLgz0ZfwNfKstKB" Content-Disposition: inline In-Reply-To: <20240306104222.308473-1-masahiroy@kernel.org> X-Smtpcorp-Track: 1rhwEj4bqxWs0u.6GksAVmg4sDH_ Feedback-ID: 1174286m:1174286a9YXZ7r:1174286smcNLppFyP X-Report-Abuse: Please forward a copy of this message, including all headers, to --QvLgz0ZfwNfKstKB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 06, 2024 at 07:42:22PM +0900 Masahiro Yamada wrote: > Commit 25b146c5b8ce ("kbuild: allow Kbuild to start from any directory") > exported abs_srctree and abs_objtree to avoid recomputation after the > sub-make. However, this approach turned out to be fragile. >=20 > Commit 5fa94ceb793e ("kbuild: set correct abs_srctree and abs_objtree > for package builds") moved them above "ifneq ($(sub_make_done),1)", > eliminating the need for exporting them. >=20 > These are only needed in the top Makefile. If an absolute path is > required in sub-directories, you can use $(abspath ) or $(realpath ) > as needed. >=20 > Signed-off-by: Masahiro Yamada > --- Thanks, I appreciate that abs_* is only used in top-level Makefile. Reviewed-by: Nicolas Schier --QvLgz0ZfwNfKstKB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEh0E3p4c3JKeBvsLGB1IKcBYmEmkFAmXouR0ACgkQB1IKcBYm Emkexg//YCqubDBQYOUGXOKDWZ4Biw/QL+kh6UNDM76LouVyCapjebmlag3VD3pm ArbuWKInK1qc+aBp0XY7G3+MqJP6hdFVGxHZ+oyNHKAWtXJ3QiZtsUY5GL006t0p 19OfoVnk2T0zlu93GQZc74Q1l3ZScOdichEZc5b5mTsc3PH+4pkETyJLTOeS4hLV WcYnUIrV2h8W021j9/xGByQlWfE707croysbSCAW5loB7u1rW2Y8E6NU4F7zjXf4 a4Z7alQybcmYYosvhkEAR8PHnXb3Q9jP5ZehH+9yw2JGUZAvep65qOe6vGAOK9g1 r1nWOTVgnOb0tbr8a0tYlfV/iWx/LI1jd79xQkRpmt7hJ36R2m+nqcoAwza6dd2B njUISzuxDTJRNU7yBY6X6+tiAMI5G4+UPAqFtcCYnYcIZ6pZSFGBeH+S+C7OGuEW k/eAaqSWZ7vbyio6utJCY7PH1OmEjzTOQKvsYr8CVmUiMix5fz8o/Kv7WZ6EQm2q BPX0e6rGYjurOnMplAIR6x3u/c75Wj/V38GnLkl4It7g6+ypaN3pAvsWc10H8Jt7 l+kampFC+1BBilJw4nq384Exhkr0q1vWvDsDO/L1NGCWDUMsy+c0CZaHYD78lFAi GzYVdP7cXFP2Ho+VrQzjbKTEa/K0yisJIghPFJVUbiK9oC1GyU4= =21AF -----END PGP SIGNATURE----- --QvLgz0ZfwNfKstKB--