From: asmadeus@codewreck.org
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Alan Maguire <alan.maguire@oracle.com>,
ast@kernel.org, andrii@kernel.org, daniel@iogearbox.net,
nathan@kernel.org, nicolas@fjasle.eu, martin.lau@linux.dev,
eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
haoluo@google.com, jolsa@kernel.org, bpf@vger.kernel.org,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH bpf-next] kbuild, bpf: reproducible BTF from pahole when KBUILD_BUILD_TIMESTAMP set
Date: Tue, 2 Jul 2024 17:20:31 +0900 [thread overview]
Message-ID: <ZoO4Ty_o4LSVfihj@codewreck.org> (raw)
In-Reply-To: <CAK7LNAStVrAx8LjDiYogRvS16-dZ+LrwcWq8gHnTbvKvR_JFFA@mail.gmail.com>
Masahiro Yamada wrote on Tue, Jul 02, 2024 at 04:58:50PM +0900:
> If --btf_features=reproducible_build has no downside,
> please add it whenever supported.
It makes the build slightly slower (from [1], 3.858 -> 3.991 (+3%) on
my crippled machine for the vmlinux BTF phase -- the modules also get
similar treatment, I'm not sure how big the total time exactly is --
for large kernels with tons of modules it definitely adds up but for small
kernels it's probably "short enough")
[1] https://lkml.kernel.org/r/20240626032253.3406460-1-asmadeus@codewreck.org
I don't particularly mind either way, so this is mostly out of curiosity:
do we have any other setting that would be closer better than this
KBUILD_BUILD_TIMESTAMP to say "make this reproducible", or is the kernel
build supposed to be reproducible except for the date by default?
Thank you,
--
Dominique Martinet | Asmadeus
next prev parent reply other threads:[~2024-07-02 8:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 17:31 [PATCH bpf-next] kbuild, bpf: reproducible BTF from pahole when KBUILD_BUILD_TIMESTAMP set Alan Maguire
2024-07-01 23:07 ` Jiri Olsa
2024-07-02 7:58 ` Masahiro Yamada
2024-07-02 8:20 ` asmadeus [this message]
2024-07-02 9:49 ` Alan Maguire
2024-07-15 11:19 ` Masahiro Yamada
2024-07-20 12:12 ` asmadeus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZoO4Ty_o4LSVfihj@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=alan.maguire@oracle.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox