From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2478373477 for ; Mon, 15 Jul 2024 21:21:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721078479; cv=none; b=W6v2BgfjP1vZr0hdcRWoPOOlOvDbwk6HNxpS3vYqNdeDgJAyQr1mqE+wU6FW91Lg1oMgSMQa98FTRzO9BPIOHzJj5AeOqr1uRvbSJjFSMWsHUabs2KLWxmEgkYjUEfOCRD/uZQ1wty/0oEjWNPikfVs2X0khT0I4uWaLeUvYmYQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721078479; c=relaxed/simple; bh=QxuwEKVXjZsdKY26h4/v6WSO1T1t9ElACgPiaHmj6U4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=n07ystnHEC2jw3CPY9vZ/evF2zdCffMWQzJXJ1nVMDsh/QAAEqE2Nx32aa+1Awf6NF13f9ttz5TqUrTEpluNxtmJBK9KLMA2nrhLFroU07cwOBXbrRDVPpEsQxovQBKD7eCx+J3yew5cPq3KJ8Bx4h7Z66zGwm33XCt1rgiPHs0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hu127ear; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hu127ear" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721078476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+J+YcViW4+se6Ty9DnL7RRzeCKJXPa01mGVrkYn2rgI=; b=hu127earyu1oyL6m2stDZndgDQfdCtOltBzHmuP6sbL+rJrftBvMfX487oVEjIRsKfpM3D l4rrDfCjeWQNLZBVDVBBaTrzQyzz9/rE8l7vrE1RWXFkZhu222m1k3eAVLth5t6m3AExWr JmzbPmKeYnhbdXuow9OU61ZgzcJDMs8= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-137-GnH9MESXMmuu7uyoiBqF_Q-1; Mon, 15 Jul 2024 17:21:14 -0400 X-MC-Unique: GnH9MESXMmuu7uyoiBqF_Q-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6b60b18e8efso83100146d6.1 for ; Mon, 15 Jul 2024 14:21:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721078474; x=1721683274; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+J+YcViW4+se6Ty9DnL7RRzeCKJXPa01mGVrkYn2rgI=; b=f7dhVJ11ViOz6elLfBJDFrgBSG1AYPCma5DonDfkAshRqOXFVDM6SasE1dDEPt1hNl B+uz4o+RDbgyphFmyWszg/4fnEFqCw0yxogetpEuwiDrCDCpSOqU0NrHly9KAQYy8Ez1 6Pf2GvlloQdETmKzrWixKK+OUUy/tpcsSxse09MvvfHt91Do+nFk6F2v/dF+flnJyeI0 aSp0cO5tA6ezCiED9TPPsp1TloTIpDQwpqE9e0PoDILtJg9YijFz6rZYPBN8K7IE1Rby R9GzKvQ7Oo+xYPeuqmhms9+/hgXc8If1yNS8k4HWIRZXPjaqZx2qPn3+2ckBPJREKjD6 9H3Q== X-Gm-Message-State: AOJu0YxQe31R6xG6K/agO+nBQN1LyN0KMR/KkpVkyFYIL1TGBTpGnWrg /GPROSSAgDxfM5pDQPIuJH1Up80cpPXANn/YWdaoPpBMh2QUMM8rsVazwIZAN4j7y+feFo745Oh 7WYOvKfV8pYQvwUOzAfhkg8QvYsYrIff2RvWddcLfghTCcy/lAxj1RlY7MkDzQewkmcocdA== X-Received: by 2002:a05:6214:f06:b0:6b5:43f2:d65e with SMTP id 6a1803df08f44-6b77f4cdd31mr5983756d6.32.1721078474055; Mon, 15 Jul 2024 14:21:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGlTQEKr+KGZW3xPOo9edF/4XcyG2agkTD6yfvAkGGhD5YrTDFFw7ZUB2kYcR3YeWPnxYqqyA== X-Received: by 2002:a05:6214:f06:b0:6b5:43f2:d65e with SMTP id 6a1803df08f44-6b77f4cdd31mr5983476d6.32.1721078473640; Mon, 15 Jul 2024 14:21:13 -0700 (PDT) Received: from optiplex-fbsd (c-174-169-122-120.hsd1.nh.comcast.net. [174.169.122.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b76198591esm24796056d6.48.2024.07.15.14.21.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jul 2024 14:21:13 -0700 (PDT) Date: Mon, 15 Jul 2024 17:21:10 -0400 From: Rafael Aquini To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Nathan Chancellor , Nicolas Schier Subject: Re: [PATCH v3 2/2] kbuild: rpm-pkg: introduce a simple changelog section for kernel.spec Message-ID: References: <20240706164423.1934390-1-aquini@redhat.com> Precedence: bulk X-Mailing-List: linux-kbuild@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Jul 16, 2024 at 01:32:56AM +0900, Masahiro Yamada wrote: > On Sun, Jul 7, 2024 at 1:45 AM Rafael Aquini wrote: > > > > Fix the following rpmbuild warning: > > > > $ make srcrpm-pkg > > ... > > RPM build warnings: > > source_date_epoch_from_changelog set but %changelog is missing > > > > Signed-off-by: Rafael Aquini > > --- > > scripts/package/mkspec | 23 +++++++++++++++++++++++ > > 1 file changed, 23 insertions(+) > > > > diff --git a/scripts/package/mkspec b/scripts/package/mkspec > > index ce201bfa8377..e45fdb12fbc7 100755 > > --- a/scripts/package/mkspec > > +++ b/scripts/package/mkspec > > @@ -28,3 +28,26 @@ cat< > EOF > > > > cat "${srctree}/scripts/package/kernel.spec" > > + > > +# collect the user's name and email address for the changelog entry > > +if [ "$(command -v git)" ]; then > > + name=$(git config user.name) || true > > + email=$(git config user.email) || true > > +fi > > + > > +if [ ! "${name:+set}" ]; then > > + name=${KBUILD_BUILD_USER:-$(id -nu)} > > +fi > > + > > +if [ ! "${email:+set}" ]; then > > + buildhost=${KBUILD_BUILD_HOST:-$(hostname -f 2>/dev/null || hostname)} > > + builduser=${KBUILD_BUILD_USER:-$(id -nu)} > > + email="${builduser}@${buildhost}" > > +fi > > + > > +cat << EOF > > + > > +%changelog > > +* $(LC_ALL=C; date +'%a %b %d %Y') ${name} <${email}> - ${KERNELRELEASE} > > > I am not sure whether the version is required or not. > > In the following guide, not all entries have the version. > > https://jfearn.fedorapeople.org/en-US/RPM/4/html/RPM_Guide/ch09s06.html > > > If you want to add the version, perhaps is it better to > follow the fedora convention? > > > The spec file of Fedora looks as follows. > The version is enclosed in the square brackets. > > %changelog > * Wed Dec 13 2023 Augusto Caringi [6.6.7-0] > - Add rhbz#2253632 rhbz#2253633 to BugsFixed (Justin M. Forbes) > - Turn on DRM_ACCEL drivers for Fedora (Justin M. Forbes) > - Linux v6.6.7 > > > > > Or, is this not important because there is no strict format? Darn, I've been using the "- release" pattern for my RPMs for quite a long time, as circa 2010 that was the suggestion. I guess I just got used to it and never really noticed the change along the way. There's not a strict format, though, and it's just nice to have the version showing in there. I have no strong feelings about the format we should be going to go with, so I'll leave it up to you. What is the format you'd prefer for the changelog entry? Leave it as it is in this patch, or adopt the Fedora standard? I'll wait for your input before refreshing this patch (or not) Cheers, -- Rafael