Re: [PATCH v4 2/3] tools build: Avoid circular .fixdep-in.o.cmd issues

Thorsten Leemhuis
2024-08-13T16:59:53Z

On 13.08.24 18:40, Brian Norris wrote:
> On Mon, Aug 12, 2024 at 08:32:29AM +0200, Thorsten Leemhuis wrote:
>> Lo! TWIMC, this change broke my daily arm64 and x86_64 Fedora vanilla RPM
>> builds on all Fedora releases when it hit -next a few days ago. Reverting
>> it fixes the problem.
>>
>> The problem is related to the RPM magic somehow, as building worked fine
>> when when I omitted stuff like "-specs=/usr/lib/rpm/redhat/redhat-
>> hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1" from the
>> make call. So the real problem might be that space somewhere.
> [...]
> I don't have a Fedora installation on hand at the moment, and the logs
> don't seem to include most of the actual kernel build logs
> (stdout+stderr of a V=1 build might help), but I think what you've
> provided so far has highlighted one possible problem -- that the new
> one-shot compile+link is ignoring HOSTCFLAGS, which were previously
> respected via tools/build/Build.include. Could you try the following
> diff? I'll cook a proper patch and description later, but for now:
>
> --- a/tools/build/Makefile
> +++ b/tools/build/Makefile
> @@ -44,4 +44,4 @@ ifneq ($(wildcard $(TMP_O)),)
> endif
>
> $(OUTPUT)fixdep: $(srctree)/tools/build/fixdep.c
> - $(QUIET_CC)$(HOSTCC) $(KBUILD_HOSTLDFLAGS) -o $@ $<
> + $(QUIET_CC)$(HOSTCC) $(HOSTCFLAGS) $(KBUILD_HOSTLDFLAGS) -o $@ $<

Many thx for looking into this. Seems that does resolve the problem (I
did not perform a full build, but without this the build fails after a
few seconds, and now it ran through).

I don't care much, but feel free to add a

Tested-by: Thorsten Leemhuis <linux@leemhuis.info>

Thx again!

Ciao, Thorsten