From: Nicolas Schier <nicolas@fjasle.eu>
To: Alexandre Courbot <gnurou@gmail.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Makefile: add $(srctree) to dependency of compile_commands.json target
Date: Sun, 4 Aug 2024 12:22:40 +0200 [thread overview]
Message-ID: <Zq9WcJnmGqjlIpIw@fjasle.eu> (raw)
In-Reply-To: <20240804055057.262682-1-gnurou@gmail.com>
On Sun, Aug 04, 2024 at 02:50:57PM +0900 Alexandre Courbot wrote:
> When trying to build the compile_commands.json target from an external
> module's directory, the following error is displayed:
>
> make[1]: *** No rule to make target 'scripts/clang-tools/gen_compile_commands.py',
> needed by 'compile_commands.json'. Stop.
>
> This is because gen_compile_commands.py was previously looked up using a
> relative path to $(srctree), but commit b1992c3772e6 ("kbuild: use
> $(src) instead of $(srctree)/$(src) for source directory") stopped
> defining VPATH for external module builds.
>
> Prefixing gen_compile_commands.py with $(srctree) fixes the problem.
>
> Fixes: b1992c3772e6 ("kbuild: use $(src) instead of $(srctree)/$(src) for source directory")
> Signed-off-by: Alexandre Courbot <gnurou@gmail.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 8ad55d6e7b60..52d7dfe4212a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1980,7 +1980,7 @@ nsdeps: modules
> quiet_cmd_gen_compile_commands = GEN $@
> cmd_gen_compile_commands = $(PYTHON3) $< -a $(AR) -o $@ $(filter-out $<, $(real-prereqs))
>
> -$(extmod_prefix)compile_commands.json: scripts/clang-tools/gen_compile_commands.py \
> +$(extmod_prefix)compile_commands.json: $(srctree)/scripts/clang-tools/gen_compile_commands.py \
> $(if $(KBUILD_EXTMOD),, vmlinux.a $(KBUILD_VMLINUX_LIBS)) \
> $(if $(CONFIG_MODULES), $(MODORDER)) FORCE
> $(call if_changed,gen_compile_commands)
> --
> 2.46.0
>
thanks, looks good to me.
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
next prev parent reply other threads:[~2024-08-04 10:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-04 5:50 [PATCH v2] Makefile: add $(srctree) to dependency of compile_commands.json target Alexandre Courbot
2024-08-04 10:22 ` Nicolas Schier [this message]
2024-08-05 6:19 ` Masahiro Yamada
2024-08-05 7:33 ` Alexandre Courbot
2024-08-06 5:34 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zq9WcJnmGqjlIpIw@fjasle.eu \
--to=nicolas@fjasle.eu \
--cc=gnurou@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).