From: Luis Chamberlain <mcgrof@kernel.org>
To: Ole Schuerks <ole0811sch@gmail.com>
Cc: linux-kbuild@vger.kernel.org, jude.gyimah@rub.de,
thorsten.berger@rub.de, deltaone@debian.org, jan.sollmann@rub.de,
masahiroy@kernel.org, linux-kernel@vger.kernel.org,
nathan@kernel.org, nicolas@fjasle.eu
Subject: Re: [PATCH v5 01/11] kconfig: Add PicoSAT interface
Date: Fri, 20 Sep 2024 04:11:36 -0700 [thread overview]
Message-ID: <Zu1YaCDMtumhAmHc@bombadil.infradead.org> (raw)
In-Reply-To: <20240920085628.51863-2-ole0811sch@gmail.com>
On Fri, Sep 20, 2024 at 10:56:18AM +0200, Ole Schuerks wrote:
> diff --git a/scripts/kconfig/install-picosat.sh b/scripts/kconfig/install-picosat.sh
> new file mode 100755
> index 000000000000..aadfa9582ecb
> --- /dev/null
> +++ b/scripts/kconfig/install-picosat.sh
> @@ -0,0 +1,29 @@
> +#!/bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +
> +psinstdir=$(mktemp -d)
> +if [ $? -ne 0 ]; then
> + echo "mktemp failed"
> + exit 1
> +fi
> +cd $psinstdir
> +wget "https://fmv.jku.at/picosat/picosat-965.tar.gz"
> +tar -xf picosat-965.tar.gz
> +cd picosat-965
> +cp makefile.in makefile.in2
> +# change soname to conform with packages for Debian and Fedora
> +sed -e "s,-soname -Xlinker libpicosat.so,-soname -Xlinker \
> + libpicosat-trace.so.0," makefile.in2 > makefile.in
> +./configure.sh -O -t --shared
> +make libpicosat.so
Imagine if the kernel did the same thing for all the libraries we use,
so this is just not scalable. Instead it would be better for you to
intent to package this onto something like debian as a library for
picosat, once and accepted then your tooling would just detect if its
present and if so use it.
Luis
next prev parent reply other threads:[~2024-09-20 11:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 8:56 [PATCH v5 00/11] kbuild, kconfig: Add support for conflict resolution Ole Schuerks
2024-09-20 8:56 ` [PATCH v5 01/11] kconfig: Add PicoSAT interface Ole Schuerks
2024-09-20 11:11 ` Luis Chamberlain [this message]
2024-09-20 8:56 ` [PATCH v5 02/11] kbuild: Add list_is_{first,last}, list_size, list_at_index, list_for_each_from Ole Schuerks
2024-09-20 8:56 ` [PATCH v5 03/11] kconfig: Add definitions Ole Schuerks
2024-09-20 8:56 ` [PATCH v5 04/11] kconfig: Add files for building constraints Ole Schuerks
2024-09-20 8:56 ` [PATCH v5 05/11] kconfig: Add files for handling expressions Ole Schuerks
2024-09-20 8:56 ` [PATCH v5 06/11] kconfig: Add files for RangeFix Ole Schuerks
2024-09-20 8:56 ` [PATCH v5 07/11] kconfig: Add files with utility functions Ole Schuerks
2024-09-20 8:56 ` [PATCH v5 08/11] kconfig: Add tools Ole Schuerks
2024-09-20 8:56 ` [PATCH v5 09/11] kconfig: Add xconfig-modifications Ole Schuerks
2024-09-20 8:56 ` [PATCH v5 10/11] kconfig: Add loader.gif Ole Schuerks
2024-09-20 8:56 ` [PATCH v5 11/11] kconfig: Add documentation for the conflict resolver Ole Schuerks
2025-01-13 16:35 ` Brendan Jackman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zu1YaCDMtumhAmHc@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=deltaone@debian.org \
--cc=jan.sollmann@rub.de \
--cc=jude.gyimah@rub.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=ole0811sch@gmail.com \
--cc=thorsten.berger@rub.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox