From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Tero Kristo" <tero.kristo@linux.intel.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"David Gow" <davidgow@google.com>
Subject: Re: [PATCH v2 1/1] platform/x86: intel: Add 'intel' prefix to the modules automatically
Date: Mon, 28 Oct 2024 15:05:48 +0200 [thread overview]
Message-ID: <Zx-MLAyyNWiQg-sq@smile.fi.intel.com> (raw)
In-Reply-To: <CAK7LNAS1xg2CLvTB-9dwGikAGNZRFOhknE_sbkxqyw=f6BNNog@mail.gmail.com>
On Mon, Oct 28, 2024 at 01:49:52PM +0100, Masahiro Yamada wrote:
> On Mon, Oct 28, 2024 at 11:58 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Wed, Oct 16, 2024 at 01:59:51PM +0300, Andy Shevchenko wrote:
> > > Rework Makefile to add 'intel' prefix to the modules automatically.
> > > This removes a lot of boilerplate code in it and also makes robust
> > > against mistypos in the prefix.
> >
> > > ---
> > >
> > > v2: fixed obvious typos (LKP), Cc'ed to Kbuild ML (Ilpo), dropped RFC marker
> > >
> > > Note to Kbuild people: TBH I rather want to have something like this
> > > to be available on the level of Kbuild for any of the subdirectories
> > > in question.
> >
> > Anyone, any comments on this?
> > This already passed a CI tests without failure so far. Perhaps it's good
> > to apply to show the demand of such a feature in Kbuild in the future?
> > Because I want to do the same for various */tests/ folders where we have
> > tons of test*, *kunit modules effectively duplicating the folder name.
>
> I do not like what you are doing here,
That's why the question is to Kbuild if it's possible to have this feature
available treewide for users in a form that you like?
> but it is up to you whatever you do in Makefiles you maintain.
Thanks! Ilpo, what do you think about applying this in its current form?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-10-28 13:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 10:59 [PATCH v2 1/1] platform/x86: intel: Add 'intel' prefix to the modules automatically Andy Shevchenko
2024-10-28 10:58 ` Andy Shevchenko
2024-10-28 12:49 ` Masahiro Yamada
2024-10-28 13:05 ` Andy Shevchenko [this message]
2024-10-31 14:39 ` Ilpo Järvinen
2024-10-31 15:19 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zx-MLAyyNWiQg-sq@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=davidgow@google.com \
--cc=geert@linux-m68k.org \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tero.kristo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox