From: Alexey Gladkov <legion@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, Petr Pavlu <petr.pavlu@suse.com>,
Ard Biesheuvel <ardb@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nicolas@fjasle.eu>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] kbuild: generate module.builtin.modinfo from vmlinux.unstripped instead of vmlinux.o
Date: Sun, 8 Jun 2025 16:44:18 +0200 [thread overview]
Message-ID: <aEWhwur_W6UwDsx_@example.org> (raw)
In-Reply-To: <20250606041029.614348-1-masahiroy@kernel.org>
On Fri, Jun 06, 2025 at 01:10:22PM +0900, Masahiro Yamada wrote:
>
> Currently, modules.builtin.modinfo is generated from vmlinux.o, which
> occurs before modpost. So, we cannot include modpost-processed data
> into modules.builtin.modinfo.
>
> This patch set allows to generate modules.builtin.modinfo from
> vmlinux.unstripped.
>
> I think this patch set will be useful to clean up this:
>
> https://lore.kernel.org/linux-kbuild/cover.1748335606.git.legion@kernel.org/T/#m98813857abf2101bdf67f1b8529a44f5c7f4746d
>
> The original approach generates modules.builtin.modinfo from two files
> and then cancatenates them into a single file.
>
> I prefer generating modules.builtin.modinfo from a single point.
>
> I think 1/4 is a good cleanup regardless of modules.builtin.modinfo
>
>
> Masahiro Yamada (4):
> module: remove meaningless 'name' parameter from __MODULE_INFO()
> kbuild: always create intermediate vmlinux.unstripped
> kbuild: keep .modinfo section in vmlinux.unstripped
> kbuild: extract modules.builtin.modinfo from vmlinux.unstripped
>
> include/asm-generic/vmlinux.lds.h | 2 +-
> include/crypto/algapi.h | 4 +-
> include/linux/module.h | 3 --
> include/linux/moduleparam.h | 9 ++--
> include/net/tcp.h | 4 +-
> scripts/Makefile.vmlinux | 73 +++++++++++++++++++++----------
> scripts/Makefile.vmlinux_o | 26 +----------
> scripts/mksysmap | 3 ++
> 8 files changed, 63 insertions(+), 61 deletions(-)
Hm. It doesn't work for me :(
I haven't been able to figure out what's wrong yet.
make[3]: *** No rule to make target 'vmlinux', needed by 'arch/x86/boot/compressed/../voffset.h'. Stop.
make[2]: *** [arch/x86/boot/Makefile:96: arch/x86/boot/compressed/vmlinux] Error 2
make[1]: *** [arch/x86/Makefile:320: bzImage] Error 2
make: *** [Makefile:248: __sub-make] Error 2
--
Rgrds, legion
prev parent reply other threads:[~2025-06-08 14:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 4:10 [PATCH 0/4] kbuild: generate module.builtin.modinfo from vmlinux.unstripped instead of vmlinux.o Masahiro Yamada
2025-06-06 4:10 ` [PATCH 1/4] module: remove meaningless 'name' parameter from __MODULE_INFO() Masahiro Yamada
2025-06-13 10:21 ` Petr Pavlu
2025-06-06 4:10 ` [PATCH 2/4] kbuild: always create intermediate vmlinux.unstripped Masahiro Yamada
2025-06-06 4:10 ` [PATCH 3/4] kbuild: keep .modinfo section in vmlinux.unstripped Masahiro Yamada
2025-06-06 12:53 ` kernel test robot
2025-06-06 4:10 ` [PATCH 4/4] kbuild: extract modules.builtin.modinfo from vmlinux.unstripped Masahiro Yamada
2025-06-07 0:46 ` kernel test robot
2025-06-11 10:38 ` Alexey Gladkov
2025-06-08 14:44 ` Alexey Gladkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEWhwur_W6UwDsx_@example.org \
--to=legion@kernel.org \
--cc=ardb@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=petr.pavlu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox