linux-kbuild.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Schier <nsc@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
	Nathan Chancellor <nathan@kernel.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH] kconfig: qconf/xconfig: show the OptionsMode radio button setting at startup
Date: Sat, 16 Aug 2025 20:49:59 +0200	[thread overview]
Message-ID: <aKDS1w_2yHd3Om26@levanger> (raw)
In-Reply-To: <20250812223502.1356426-1-rdunlap@infradead.org>

[-- Attachment #1: Type: text/plain, Size: 1424 bytes --]

On Tue, Aug 12, 2025 at 03:35:02PM -0700, Randy Dunlap wrote:
> When qconf (xconfig) exits, it saves the current Option settings
> for Show Name, Show Debug Info, and Show {Normal|All|Prompt} Options.
> When it is next run, it loads these Option settings from its
> config file. It correctly shows the flag settings for Show Name
> and Show Debug Info, but it does not show which of the 3 Show...Options
> is set. This can lead to confusing output, e.g., if the user thinks
> that xconfig is in Show All Options mode but kconfig options which
> have an unmet dependency are still being listed.
> 
> Add code to show the radio button for the current Show...Options
> mode during startup so that it will reflect the current config
> setting.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Nathan, Nicolas: do you want me to ask someone else to merge this?
>   I don't mind doing that;
>   or throw it into your tree and see what breaks.
> 
> I know next to nothing about the Qt toolkit, so any comments or
> testing are appreciated. There could easily be a better fix for this.
> Thanks.

Thanks for the fix!  I cannot review this properly but reasoning is
straightforward and testing reveals that its really useful.

Tested-by: Nicolas Schier <nsc@kernel.org>
Acked-by: Nicolas Schier <nsc@kernel.org>


Nathan,  can you take this into kbuild-next?

Kind regards,
Nicolas

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2025-08-16 18:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-12 22:35 [PATCH] kconfig: qconf/xconfig: show the OptionsMode radio button setting at startup Randy Dunlap
2025-08-16 18:49 ` Nicolas Schier [this message]
2025-08-18 18:14 ` Nathan Chancellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aKDS1w_2yHd3Om26@levanger \
    --to=nsc@kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=nathan@kernel.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).