From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADE822FD1B1; Mon, 25 Aug 2025 15:39:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756136366; cv=none; b=JGJDDPkNYvTFXHUJ9kBzJKKu2hoC8BWt+A36RJY38rqR5VOhJElI7IiuClUJTMN5HG4zJCObFr/ZO+14h2LEhzBMP02RnP2emLYR+ParaBxMcwZlyggY6kSipvwdU6fUFKzVPQxutcKBNFTnT5wjxRVa3RUiRIR35FnvTIMgr44= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756136366; c=relaxed/simple; bh=wDX72lFXC9Zc3267BybmSNThL9SXJrH+3OnweEOr3JY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mZ3zsku4ETn4W8hz/fY1n2R8p6jsWg8aCv7fU1JN+Xn+pAgFj8lWlgyZV79mvTitWJZYhevSn+Ih4YwHxBp12Sl4fwukiDFoJA1ZCbB+Ld/QZ6yqG21a69ZdIDg010Ks1I0iEIEdQUdFqKbTIyH89Cu83waWT9Not7mfzN7IZUM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TykLHZcA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TykLHZcA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2363C4CEED; Mon, 25 Aug 2025 15:39:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1756136366; bh=wDX72lFXC9Zc3267BybmSNThL9SXJrH+3OnweEOr3JY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TykLHZcAmyav7iJuotWPm5t8m+TvFyNAhkljwLCNm9je3JAujyK/AClrcJmncLE/F C0pBqAfAYY0Vm1UyecmOSzy79zpgMczYcRCQr0rLaEvAbo8TlcQk3Bn/mC8OfeqGaj Z9ciVHGUox5vNj2NaAXS1dudRTDqfgUL2ckSNg3svdyE/ALeb00eNWLVaZyKejFejD Go53C6scUEJn1hQGAGMXQSrkevCtvCWn/Gks88XJKONj9CDzdrmtQEVqsFSwcPWixf WISE4wDACTqXkxm645PjLlkyUGhsxTLdjJrfPgZwQZvschB1FeoPg9tOYXZtT2d6Pi puaYoQAQG9TLw== Date: Mon, 25 Aug 2025 17:33:12 +0200 From: Nicolas Schier To: Vlastimil Babka Cc: Nathan Chancellor , Christian Brauner , Daniel Gomez , Masahiro Yamada , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org Subject: Re: [PATCH] scripts/misc-check: update export checks for EXPORT_SYMBOL_FOR_MODULES() Message-ID: References: <20250825-export_modules_fix-v1-1-5c331e949538@suse.cz> Precedence: bulk X-Mailing-List: linux-kbuild@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250825-export_modules_fix-v1-1-5c331e949538@suse.cz> On Mon, Aug 25, 2025 at 05:00:37PM +0200, Vlastimil Babka wrote: > The module export checks are looking for EXPORT_SYMBOL_GPL_FOR_MODULES() > which was renamed to EXPORT_SYMBOL_FOR_MODULES(). Update the checks. > > Fixes: 6d3c3ca4c77e ("module: Rename EXPORT_SYMBOL_GPL_FOR_MODULES to EXPORT_SYMBOL_FOR_MODULES") > Signed-off-by: Vlastimil Babka > --- > I've missed these new checks when renaming the export macro due to my > git grep being too narrow. My commit went through Christian's vfs tree > but seems the script is part of kbuild (which is currently Odd fixes). > --- > scripts/misc-check | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Good catch, thanks a lot! We will gladly take the patch to kbuild-next. Reviewed-by: Nicolas Schier