* [PATCH] kbuild: uapi: Drop check_config()
@ 2025-12-30 7:09 Thomas Weißschuh
2025-12-30 8:27 ` Nicolas Schier
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Weißschuh @ 2025-12-30 7:09 UTC (permalink / raw)
To: Nathan Chancellor, Nicolas Schier
Cc: linux-kbuild, linux-kernel, Thomas Weißschuh
headers_install.sh already tests for CONFIG symbols. It does so in a
more comprehensive way, by only checking for references in code and
also running even if CONFIG_UAPI_HEADER_TEST is disabled.
And check_config() has been disabled any case.
Drop the pointless check.
Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
---
| 8 --------
1 file changed, 8 deletions(-)
--git a/usr/include/headers_check.pl b/usr/include/headers_check.pl
index af5a513eaa00..6cd6eb652c8d 100755
--- a/usr/include/headers_check.pl
+++ b/usr/include/headers_check.pl
@@ -40,7 +40,6 @@ foreach my $file (@files) {
&check_include();
&check_asm_types();
&check_declarations();
- # Dropped for now. Too much noise &check_config();
}
close $fh;
}
@@ -77,13 +76,6 @@ sub check_declarations
}
}
-sub check_config
-{
- if ($line =~ m/[^a-zA-Z0-9_]+CONFIG_([a-zA-Z0-9_]+)[^a-zA-Z0-9_]/) {
- printf STDERR "$filename:$lineno: leaks CONFIG_$1 to userspace where it is not valid\n";
- }
-}
-
my $linux_asm_types;
sub check_asm_types
{
---
base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8
change-id: 20251229-uapi-check_config-8aa43e365846
Best regards,
--
Thomas Weißschuh <thomas.weissschuh@linutronix.de>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kbuild: uapi: Drop check_config()
2025-12-30 7:09 [PATCH] kbuild: uapi: Drop check_config() Thomas Weißschuh
@ 2025-12-30 8:27 ` Nicolas Schier
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Schier @ 2025-12-30 8:27 UTC (permalink / raw)
To: Thomas Weißschuh; +Cc: Nathan Chancellor, linux-kbuild, linux-kernel
On Tue, Dec 30, 2025 at 08:09:29AM +0100, Thomas Weißschuh wrote:
> headers_install.sh already tests for CONFIG symbols. It does so in a
> more comprehensive way, by only checking for references in code and
> also running even if CONFIG_UAPI_HEADER_TEST is disabled.
> And check_config() has been disabled any case.
>
> Drop the pointless check.
>
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> ---
> usr/include/headers_check.pl | 8 --------
> 1 file changed, 8 deletions(-)
Thanks for spotting!
Reviewed-by: Nicolas Schier <nsc@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-30 8:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-30 7:09 [PATCH] kbuild: uapi: Drop check_config() Thomas Weißschuh
2025-12-30 8:27 ` Nicolas Schier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).