From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 820DF3F54DD; Wed, 18 Mar 2026 19:57:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773863837; cv=none; b=Rkw/+wzepqRouD5VQy9I42hnFrBDYCdY4ZPZXfz1m5hZ0hcZA34xJkYI1F/oq3ABbZnh9a25Y9MM4lLXOu3y7VlK/J56iIhOhYnjc2C55nxYQgPMWr8Z1/drScx1gMnjtseu/9BPxLTpatYyd4V8Q5F7TMD6MpoD5CoI67MszRM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773863837; c=relaxed/simple; bh=FE2ttuvV+KBb44hFRvqmh0FjK3w624gREPleu9qGu4M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=t1ceFa5L0U4n8woJ+ALo3TspfGLExws/izeQ4vGj2ut+SId9OJDypuEuZ2+DRSCyo+qD0SIrIQ3VzR2DfZyELVRWcPa42E6agGCDheqhUnetGq1wfM7msMa8n8LbmhrCam2O3X2n536EEa+sv7Ej58c+WNZT947hrbIprfWirfU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CPA3lDa2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CPA3lDa2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7BCDC2BCAF; Wed, 18 Mar 2026 19:57:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773863837; bh=FE2ttuvV+KBb44hFRvqmh0FjK3w624gREPleu9qGu4M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CPA3lDa25LYpMQlNVSQE7creOvrQaav7OfPs8GWdjcrcKMQhr6VYqEaOekX5MKXSL jSvDTGiY+jvipCaXAAfF1Hkfmni2l+dCpaK3QlMs43T9U4DfE+hMtj7G+joJPy4dIf dL1u5WJVx3bnpUoSGCjnNCHKnjSrTAbwofsWMHnRrf8O43Ere6llSHcjtxeWwjPyNE iEG623GXDkKrdfm4lnBOY94/Y4Xs/bFMmKueZa/8pJN8rQtML+TFCHzC0L3nJ1hUD/ CUnpwTa+eQ0OhOd5KHbjFpEW9hbzPJZyRuqH7013XRjyVbEW6hLEqkLXjFyg2saNzX D/5DSLR7rG/VQ== Date: Wed, 18 Mar 2026 20:56:50 +0100 From: Nicolas Schier To: Oli Cc: Thomas Gleixner , Ingo Molnar , Steven Rostedt , Mathieu Desnoyers , Masami Hiramatsu , Rodolfo Giometti , Henrik Rydberg , Dmitry Torokhov , Nathan Chancellor , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-input@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH] Remove unused headers in x86/tools, scripts, pps, input Message-ID: References: Precedence: bulk X-Mailing-List: linux-kbuild@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Oli, thanks for your contribution. Some comments below: On Tue, Mar 10, 2026 at 10:01:41PM -0500, Oli wrote: > From c78a0572f5ec2b927f9b723af687e6ef913561a4 Mon Sep 17 00:00:00 2001 > From: Eddie Hudgins > Date: Tue, 10 Mar 2026 21:53:07 -0500 > Subject: [PATCH] Signed-off-by: Eddie Hudgins > arch/x86/tools: Removed headers in relocs_32.c scripts/basic: Removed > headers > in fixdep.c drivers/pps: Removed headers in pps.c drivers/input: Removed > headers in input-mt.c Usually, patch mails do not contain mail headers within their body; the only possible exception is 'From:' if the sender is not the patch author. These additional headers prevent the usual patch application (e.g. 'git am > These changes compile for x86, x86_64, and powerpc (Those were the only > ones fairly tested) under defconfig. This aims to clean up code and > simplify the files for developers. This will also contribute to start of > decluttering the environment. A commit subject should start with a subsystem identifier. A commit message should tell about the what and why of the patch, followed by a 'Signed-of-by'. E.g.: kbuild: fixdep: Remove unused includes Remove unused #include statements for clean up. Signed-off-by: Your Name (More complex changes require more details commit message). Please check Documentation/process/submitting-patches.rst. [...] > diff --git a/scripts/basic/fixdep.c b/scripts/basic/fixdep.c > index cdd5da7e009b..feb9e7d8984d 100644 > --- a/scripts/basic/fixdep.c > +++ b/scripts/basic/fixdep.c > @@ -89,7 +89,6 @@ > * but I don't think the added complexity is worth it) > */ > > -#include > #include > #include > #include > -- > 2.43.0 The change in scripts/basic/fixdep.c looks good to me. Do you want to prepare a new kbuild-only patch and want me to take it for kbuild? Kind regards, Nicolas