From: Jiri Slaby <jslaby@suse.cz>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH] scripts: dummy-tools, add pahole
Date: Thu, 14 Apr 2022 11:42:07 +0200 [thread overview]
Message-ID: <ace87421-eefb-f4f6-307f-cd2990fb25eb@suse.cz> (raw)
In-Reply-To: <CAK7LNATn2QrFn0fTixnbtZ-VOtWid2PvFKPmjfX+z_UtZgTMgA@mail.gmail.com>
On 14. 04. 22, 11:33, Masahiro Yamada wrote:
> On Thu, Apr 14, 2022 at 6:14 PM Jiri Slaby <jslaby@suse.cz> wrote:
>>
>> CONFIG_PAHOLE_VERSION is a part of a config since the commit below. And
>> when multiple people update the config, this value constantly changes.
>> Even if they use dummy scripts.
>>
>> To fix this:
>> * add a pahole dummy script returning v99.99 -> 9999
>> * call it in Makefile taking CROSS_COMPILE into account.
>>
>> The latter happens only if $(CROSS_COMPILE)pahole really exists. This is
>> because a cross pahole likely exists only in dummy tools now, not in
>> real cross tools.
>
>
> I do not think this is the right thing to do.
>
> (As I said somewhere, I am opposed to checking pahole version in Kconfig).
If you ask me, I am all for removal as this causes pain. But it's there,
so I cannot do anything about that.
> Also, $(CROSS_COMPILE)pahole looks insane.
>
> You can create a dummy pahole in your local system.
>
> $ echo 'echo v99.99' > $HOME/bin/dummy-pahole
> $ chmod +x $HOME/bin/dummy-pahole
> $ make CROSS_COMPILE=scripts/dummy-tools PAHOLE=dummy-pahole menuconfig
Well, the question is how do I that for every kernel developer in SUSE?
thanks,
--
js
suse labs
next prev parent reply other threads:[~2022-04-14 9:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 9:14 [PATCH] scripts: dummy-tools, add pahole Jiri Slaby
2022-04-14 9:33 ` Masahiro Yamada
2022-04-14 9:42 ` Jiri Slaby [this message]
2022-04-14 9:44 ` Jiri Slaby
2022-04-14 15:18 ` Masahiro Yamada
2022-04-19 6:23 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ace87421-eefb-f4f6-307f-cd2990fb25eb@suse.cz \
--to=jslaby@suse.cz \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox