Re: [PATCH] Fix CONFIG_CROSS_COMPILE issue in .config

Re: [PATCH] Fix CONFIG_CROSS_COMPILE issue in .config

[Andrew Morton]

On Thu, 17 Jun 2010 12:50:52 +0000
Tiago Maluta <tiago.maluta@gmail.com> wrote:

> Linux has an recent option to define CROSS_COMPILE in menuconfig.
> 
> Typically, one of the options when building for another target is
> ('arm' is just an example):
> 
> # make ARCH=arm CROSS_COMPILE=arm-cc O=../build
> 
> If I omit CROSS_COMPILE and use the new way in .config:
> CONFIG_CROSS_COMPILE="arm-cc"
> 
> I got:
> 
>    cc1: error: unrecognized command line option "-mlittle-endian"
>    cc1: error: unrecognized command line option "-mabi=aapcs-linux"
>    cc1: error: unrecognized command line option "-mno-thumb-interwork"
>    /usr/src/linux/kernel/bounds.c:1: error: bad value (armv5t) for
> -march= switch
>    /usr/src/linux/kernel/bounds.c:1: error: bad value (armv5t) for
> -mtune= switch
>    make[2]: *** [kernel/bounds.s] Error 1
>    make[1]: *** [prepare0] Error 2
>    make: *** [sub-make] Error 2
> 
> Verbose output clearly says that I'm using the host compiler instead
> cross compiler.
> This patch fixed my problem:
> 
> ---
> __Makefile |______ 2 +-
> __1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index d49d96c..5a6c7d5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -190,7 +190,7 @@ SUBARCH := $(shell uname -m | sed -e s/i.86/i386/
> -e s/sun4u/sparc64/ \
> __export KBUILD_BUILDHOST := $(SUBARCH)
> __ARCH____________________ ?= $(SUBARCH)
> __CROSS_COMPILE__ ?=
> -CROSS_COMPILE__ ?= $(CONFIG_CROSS_COMPILE:"%"=%)
> +CROSS_COMPILE__ := $(shell grep CONFIG_CROSS_COMPILE .config | cut -d'"' -f2)
> 
> __# Architecture as present in compile.h
> __UTS_MACHINE______ := $(ARCH)
> --

Perhaps the "%"=% thing isn't supported with your version of make(1). 
Which version are you using?

Directly grepping .config probably isn't the right thing to do. 
Maybe `patsubst' can be used here.



Administrivia:

Your email client wordwraps the patches and replaces tabs with weird
non-ascii characters.  

Please include a Signed-off-by: with patches, as described in
Documentation/SubmittingPatches, thanks.

Re: [PATCH] Fix CONFIG_CROSS_COMPILE issue in .config

[Roland McGrath]

> Perhaps the "%"=% thing isn't supported with your version of make(1). 
> Which version are you using?

There isn't a version of make capable of doing kbuild at all
that doesn't support that syntax.

> Directly grepping .config probably isn't the right thing to do. 
> Maybe `patsubst' can be used here.

The :"%"=% syntax is the same as patsubst.


Thanks,
Roland

Re: [PATCH] Fix CONFIG_CROSS_COMPILE issue in .config

[Michal Marek]

On 21.6.2010 21:06, Andrew Morton wrote:
> On Thu, 17 Jun 2010 12:50:52 +0000
> Tiago Maluta <tiago.maluta@gmail.com> wrote:
> 
>> Linux has an recent option to define CROSS_COMPILE in menuconfig.
>>
>> Typically, one of the options when building for another target is
>> ('arm' is just an example):
>>
>> # make ARCH=arm CROSS_COMPILE=arm-cc O=../build
>>
>> If I omit CROSS_COMPILE and use the new way in .config:
>> CONFIG_CROSS_COMPILE="arm-cc"
>>
>> I got:
>>
>>    cc1: error: unrecognized command line option "-mlittle-endian"
>>    cc1: error: unrecognized command line option "-mabi=aapcs-linux"
>>    cc1: error: unrecognized command line option "-mno-thumb-interwork"
>>    /usr/src/linux/kernel/bounds.c:1: error: bad value (armv5t) for
>> -march= switch
>>    /usr/src/linux/kernel/bounds.c:1: error: bad value (armv5t) for
>> -mtune= switch
>>    make[2]: *** [kernel/bounds.s] Error 1
>>    make[1]: *** [prepare0] Error 2
>>    make: *** [sub-make] Error 2
>>
>> Verbose output clearly says that I'm using the host compiler instead
>> cross compiler.
>> This patch fixed my problem:
>>
>> ---
>> __Makefile |______ 2 +-
>> __1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index d49d96c..5a6c7d5 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -190,7 +190,7 @@ SUBARCH := $(shell uname -m | sed -e s/i.86/i386/
>> -e s/sun4u/sparc64/ \
>> __export KBUILD_BUILDHOST := $(SUBARCH)
>> __ARCH____________________ ?= $(SUBARCH)
>> __CROSS_COMPILE__ ?=
>> -CROSS_COMPILE__ ?= $(CONFIG_CROSS_COMPILE:"%"=%)
>> +CROSS_COMPILE__ := $(shell grep CONFIG_CROSS_COMPILE .config | cut -d'"' -f2)
>>
>> __# Architecture as present in compile.h
>> __UTS_MACHINE______ := $(ARCH)
>> --
> 
> Perhaps the "%"=% thing isn't supported with your version of make(1). 
> Which version are you using?

My guess is that something expands $(CROSS_COMPILE) before make
silentoldconfig generates include/config/auto.conf (which is where the
makefile reads the CONFIG_* variables from). Tiago, can you try changing
the $(shell ...) line to

CROSS_COMPILE := $(shell ls include/config/auto.conf >&2; \
    echo "CONFIG_CROSS_COMPILE $(CONFIG_CROSS_COMPILE) >&2; \
    grep CONFIG_CROSS_COMPILE .config | cut -d'"'  -f2)

and tell us what it prints?

Thanks,
Michal

Re: [PATCH] Fix CONFIG_CROSS_COMPILE issue in .config

[Tiago Maluta]

On Mon, Jun 21, 2010 at 4:54 PM, Michal Marek <mmarek@suse.cz> wrote:
> On 21.6.2010 21:06, Andrew Morton wrote:
>> On Thu, 17 Jun 2010 12:50:52 +0000
>> Tiago Maluta <tiago.maluta@gmail.com> wrote:
>>
>>> Linux has an recent option to define CROSS_COMPILE in menuconfig.
>>>
>>> Typically, one of the options when building for another target is
>>> ('arm' is just an example):
>>>
>>> # make ARCH=arm CROSS_COMPILE=arm-cc O=../build
>>>
>>> If I omit CROSS_COMPILE and use the new way in .config:
>>> CONFIG_CROSS_COMPILE="arm-cc"
>>>
>>> I got:
>>>
>>>    cc1: error: unrecognized command line option "-mlittle-endian"
>>>    cc1: error: unrecognized command line option "-mabi=aapcs-linux"
>>>    cc1: error: unrecognized command line option "-mno-thumb-interwork"
>>>    /usr/src/linux/kernel/bounds.c:1: error: bad value (armv5t) for
>>> -march= switch
>>>    /usr/src/linux/kernel/bounds.c:1: error: bad value (armv5t) for
>>> -mtune= switch
>>>    make[2]: *** [kernel/bounds.s] Error 1
>>>    make[1]: *** [prepare0] Error 2
>>>    make: *** [sub-make] Error 2
>>>
>>> Verbose output clearly says that I'm using the host compiler instead
>>> cross compiler.
>>> This patch fixed my problem:
>>>
>>> ---
>>> __Makefile |______ 2 +-
>>> __1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/Makefile b/Makefile
>>> index d49d96c..5a6c7d5 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -190,7 +190,7 @@ SUBARCH := $(shell uname -m | sed -e s/i.86/i386/
>>> -e s/sun4u/sparc64/ \
>>> __export KBUILD_BUILDHOST := $(SUBARCH)
>>> __ARCH____________________ ?= $(SUBARCH)
>>> __CROSS_COMPILE__ ?=
>>> -CROSS_COMPILE__ ?= $(CONFIG_CROSS_COMPILE:"%"=%)
>>> +CROSS_COMPILE__ := $(shell grep CONFIG_CROSS_COMPILE .config | cut -d'"' -f2)
>>>
>>> __# Architecture as present in compile.h
>>> __UTS_MACHINE______ := $(ARCH)
>>> --
>>
>> Perhaps the "%"=% thing isn't supported with your version of make(1).
>> Which version are you using?
>
> My guess is that something expands $(CROSS_COMPILE) before make
> silentoldconfig generates include/config/auto.conf (which is where the
> makefile reads the CONFIG_* variables from). Tiago, can you try changing
> the $(shell ...) line to
>
> CROSS_COMPILE := $(shell ls include/config/auto.conf >&2; \
>    echo "CONFIG_CROSS_COMPILE $(CONFIG_CROSS_COMPILE) >&2; \
>    grep CONFIG_CROSS_COMPILE .config | cut -d'"'  -f2)
>
> and tell us what it prints?

I'm using GNU Make 3.81.

I think you missed a quote in echo..., I using:

CROSS_COMPILE := $(shell ls include/config/auto.conf >&2; \
    echo "CONFIG_CROSS_COMPILE" $(CONFIG_CROSS_COMPILE) >&2; \
    grep CONFIG_CROSS_COMPILE .config | cut -d'"'  -f2)

And the output:
$ make ARCH=arm O=../build

include/config/auto.conf
CONFIG_CROSS_COMPILE
  Using /usr/src/linux as source for kernel
  GEN     /usr/src/build/Makefile
  CHK     include/linux/version.h
  CHK     include/generated/utsrelease.h
make[2]: `include/generated/mach-types.h' is up to date.
  CALL    /usr/src/linux/scripts/checksyscalls.sh
  CHK     include/generated/compile.h
  CC      arch/arm/mm/init.o

^C

Means that is nothing CONFIG_CROSS_COMPILE.

I agree with Andrew, directly grepping .config isn't the right thing to do.
I'd like to discuss a better solution.

--tm

Re: [PATCH] Fix CONFIG_CROSS_COMPILE issue in .config

[Yegor Yefremov]

On Wed, Jun 23, 2010 at 5:44 AM, Tiago Maluta <tiago.maluta@gmail.com> wrote:
> On Mon, Jun 21, 2010 at 4:54 PM, Michal Marek <mmarek@suse.cz> wrote:
>> On 21.6.2010 21:06, Andrew Morton wrote:
>>> On Thu, 17 Jun 2010 12:50:52 +0000
>>> Tiago Maluta <tiago.maluta@gmail.com> wrote:
>>>
>>>> Linux has an recent option to define CROSS_COMPILE in menuconfig.
>>>>
>>>> Typically, one of the options when building for another target is
>>>> ('arm' is just an example):
>>>>
>>>> # make ARCH=arm CROSS_COMPILE=arm-cc O=../build
>>>>
>>>> If I omit CROSS_COMPILE and use the new way in .config:
>>>> CONFIG_CROSS_COMPILE="arm-cc"
>>>>
>>>> I got:
>>>>
>>>>    cc1: error: unrecognized command line option "-mlittle-endian"
>>>>    cc1: error: unrecognized command line option "-mabi=aapcs-linux"
>>>>    cc1: error: unrecognized command line option "-mno-thumb-interwork"
>>>>    /usr/src/linux/kernel/bounds.c:1: error: bad value (armv5t) for
>>>> -march= switch
>>>>    /usr/src/linux/kernel/bounds.c:1: error: bad value (armv5t) for
>>>> -mtune= switch
>>>>    make[2]: *** [kernel/bounds.s] Error 1
>>>>    make[1]: *** [prepare0] Error 2
>>>>    make: *** [sub-make] Error 2
>>>>
>>>> Verbose output clearly says that I'm using the host compiler instead
>>>> cross compiler.
>>>> This patch fixed my problem:
>>>>
>>>> ---
>>>> __Makefile |______ 2 +-
>>>> __1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/Makefile b/Makefile
>>>> index d49d96c..5a6c7d5 100644
>>>> --- a/Makefile
>>>> +++ b/Makefile
>>>> @@ -190,7 +190,7 @@ SUBARCH := $(shell uname -m | sed -e s/i.86/i386/
>>>> -e s/sun4u/sparc64/ \
>>>> __export KBUILD_BUILDHOST := $(SUBARCH)
>>>> __ARCH____________________ ?= $(SUBARCH)
>>>> __CROSS_COMPILE__ ?=
>>>> -CROSS_COMPILE__ ?= $(CONFIG_CROSS_COMPILE:"%"=%)
>>>> +CROSS_COMPILE__ := $(shell grep CONFIG_CROSS_COMPILE .config | cut -d'"' -f2)
>>>>
>>>> __# Architecture as present in compile.h
>>>> __UTS_MACHINE______ := $(ARCH)
>>>> --
>>>
>>> Perhaps the "%"=% thing isn't supported with your version of make(1).
>>> Which version are you using?
>>
>> My guess is that something expands $(CROSS_COMPILE) before make
>> silentoldconfig generates include/config/auto.conf (which is where the
>> makefile reads the CONFIG_* variables from). Tiago, can you try changing
>> the $(shell ...) line to
>>
>> CROSS_COMPILE := $(shell ls include/config/auto.conf >&2; \
>>    echo "CONFIG_CROSS_COMPILE $(CONFIG_CROSS_COMPILE) >&2; \
>>    grep CONFIG_CROSS_COMPILE .config | cut -d'"'  -f2)
>>
>> and tell us what it prints?
>
> I'm using GNU Make 3.81.
>
> I think you missed a quote in echo..., I using:
>
> CROSS_COMPILE := $(shell ls include/config/auto.conf >&2; \
>    echo "CONFIG_CROSS_COMPILE" $(CONFIG_CROSS_COMPILE) >&2; \
>    grep CONFIG_CROSS_COMPILE .config | cut -d'"'  -f2)
>
> And the output:
> $ make ARCH=arm O=../build
>
> include/config/auto.conf
> CONFIG_CROSS_COMPILE
>  Using /usr/src/linux as source for kernel
>  GEN     /usr/src/build/Makefile
>  CHK     include/linux/version.h
>  CHK     include/generated/utsrelease.h
> make[2]: `include/generated/mach-types.h' is up to date.
>  CALL    /usr/src/linux/scripts/checksyscalls.sh
>  CHK     include/generated/compile.h
>  CC      arch/arm/mm/init.o
>
> ^C
>
> Means that is nothing CONFIG_CROSS_COMPILE.
>
> I agree with Andrew, directly grepping .config isn't the right thing to do.
> I'd like to discuss a better solution.

What about such a solution:

just remove empty  CROSS_COMPILE  ?=

Regards,
Yegor

Fix CONFIG_CROSS_COMPILE issue in .config

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

Index: b/Makefile
===================================================================
--- a/Makefile	2010-08-02 00:11:14.000000000 +0200
+++ b/Makefile	2010-08-04 14:08:51.000000000 +0200
@@ -189,7 +189,6 @@
 # Note: Some architectures assign CROSS_COMPILE in their arch/*/Makefile
 export KBUILD_BUILDHOST := $(SUBARCH)
 ARCH		?= $(SUBARCH)
-CROSS_COMPILE	?=
 CROSS_COMPILE	?= $(CONFIG_CROSS_COMPILE:"%"=%)

 # Architecture as present in compile.h

Re: [PATCH] Fix CONFIG_CROSS_COMPILE issue in .config

[Roland Dreier]

 > What about such a solution:
 > 
 > just remove empty  CROSS_COMPILE  ?=
 > 
 > Fix CONFIG_CROSS_COMPILE issue in .config
 > 
 > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
 > 
 > Index: b/Makefile
 > ===================================================================
 > --- a/Makefile	2010-08-02 00:11:14.000000000 +0200
 > +++ b/Makefile	2010-08-04 14:08:51.000000000 +0200
 > @@ -189,7 +189,6 @@
 >  # Note: Some architectures assign CROSS_COMPILE in their arch/*/Makefile
 >  export KBUILD_BUILDHOST := $(SUBARCH)
 >  ARCH		?= $(SUBARCH)
 > -CROSS_COMPILE	?=
 >  CROSS_COMPILE	?= $(CONFIG_CROSS_COMPILE:"%"=%)

Yes, this make sense to me.  It's not clear to me why we ever needed
the conditional assignment of an empty CROSS_COMPILE (that code predates
the start of git history) but clearly having two "?=" assignments one
after another cannot work -- the second assignment to CROSS_COMPILE will
never do anything, since the line before makes CROSS_COMPILE defined.

 - R.
-- 
Roland Dreier <rolandd@cisco.com> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html

Re: [PATCH] Fix CONFIG_CROSS_COMPILE issue in .config

[Roland McGrath]

> Yes, this make sense to me.  It's not clear to me why we ever needed
> the conditional assignment of an empty CROSS_COMPILE (that code predates
> the start of git history) [...]

Perhaps someone used make --warn-undefined-variables.

Re: [PATCH] Fix CONFIG_CROSS_COMPILE issue in .config

[Yegor Yefremov]

On Fri, Aug 6, 2010 at 12:26 AM, Roland McGrath <roland@redhat.com> wrote:
>> Yes, this make sense to me.  It's not clear to me why we ever needed
>> the conditional assignment of an empty CROSS_COMPILE (that code predates
>> the start of git history) [...]
>
> Perhaps someone used make --warn-undefined-variables.

Are there any other comments or is the patch valid? Should I resend it
as a new thread?

Regards,
Yegor

Re: [PATCH] Fix CONFIG_CROSS_COMPILE issue in .config

[Roland McGrath]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=unknown, Size: 543 bytes --]

> On Fri, Aug 6, 2010 at 12:26 AM, Roland McGrath <roland@redhat.com> wrote:
> >> Yes, this make sense to me.  It's not clear to me why we ever needed
> >> the conditional assignment of an empty CROSS_COMPILE (that code predates
> >> the start of git history) [...]
> >
> > Perhaps someone used make --warn-undefined-variables.
> 
> Are there any other comments or is the patch valid? Should I resend it
> as a new thread?

The patch is fine.  The comments were just about how it might have gotten
to be how it was before now.

Thanks,
Roland

Re: [PATCH] Fix CONFIG_CROSS_COMPILE issue in .config

[Michal Marek]

On 10.8.2010 08:43, Yegor Yefremov wrote:
> On Fri, Aug 6, 2010 at 12:26 AM, Roland McGrath <roland@redhat.com> wrote:
>>> Yes, this make sense to me.  It's not clear to me why we ever needed
>>> the conditional assignment of an empty CROSS_COMPILE (that code predates
>>> the start of git history) [...]
>>
>> Perhaps someone used make --warn-undefined-variables.
> 
> Are there any other comments or is the patch valid? Should I resend it
> as a new thread?

No problem at your side, the patch is fine and I applied it now.

Michal

Re: [PATCH] Fix CONFIG_CROSS_COMPILE issue in .config

[Andrew Hendry]

This gives some errors on my ubuntu build for -rc1, reverting lets it
build normally. Am I missing something?

ahendry@ubuntu:~/linux/linux-2.6$ make
make: ngcc: Command not found
  CHK     include/linux/version.h
  CHK     include/generated/utsrelease.h
  CC      kernel/bounds.s
/bin/sh: ngcc: not found
make[1]: *** [kernel/bounds.s] Error 127
make: *** [prepare0] Error 2

.config has CONFIG_CROSS_COMPILE="n"

On Tue, Aug 10, 2010 at 9:21 PM, Michal Marek <mmarek@suse.cz> wrote:
> On 10.8.2010 08:43, Yegor Yefremov wrote:
>> On Fri, Aug 6, 2010 at 12:26 AM, Roland McGrath <roland@redhat.com> wrote:
>>>> Yes, this make sense to me.  It's not clear to me why we ever needed
>>>> the conditional assignment of an empty CROSS_COMPILE (that code predates
>>>> the start of git history) [...]
>>>
>>> Perhaps someone used make --warn-undefined-variables.
>>
>> Are there any other comments or is the patch valid? Should I resend it
>> as a new thread?
>
> No problem at your side, the patch is fine and I applied it now.
>
> Michal
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

Re: [PATCH] Fix CONFIG_CROSS_COMPILE issue in .config

[Michal Marek]

Dne 16.8.2010 14:35, Andrew Hendry napsal(a):
> This gives some errors on my ubuntu build for -rc1, reverting lets it
> build normally. Am I missing something?
> 
> ahendry@ubuntu:~/linux/linux-2.6$ make
> make: ngcc: Command not found
>   CHK     include/linux/version.h
>   CHK     include/generated/utsrelease.h
>   CC      kernel/bounds.s
> /bin/sh: ngcc: not found
> make[1]: *** [kernel/bounds.s] Error 127
> make: *** [prepare0] Error 2
> 
> .config has CONFIG_CROSS_COMPILE="n"

CONFIG_CROSS_COMPILE is a string option, leave it empty if you are not
cross compiling.

Michal.

Re: [PATCH] Fix CONFIG_CROSS_COMPILE issue in .config

[Andrew Hendry]

Thanks Michal, can see the problem now.
Not sure how the "n" got there, i didn't set it manually.
Was at 2.6.35-rc6 then updated to 2.6.36-rc1 taking the defaults for
all the new config options that popped up.

On Mon, Aug 16, 2010 at 10:40 PM, Michal Marek <mmarek@suse.cz> wrote:
> Dne 16.8.2010 14:35, Andrew Hendry napsal(a):
>> This gives some errors on my ubuntu build for -rc1, reverting lets it
>> build normally. Am I missing something?
>>
>> ahendry@ubuntu:~/linux/linux-2.6$ make
>> make: ngcc: Command not found
>>   CHK     include/linux/version.h
>>   CHK     include/generated/utsrelease.h
>>   CC      kernel/bounds.s
>> /bin/sh: ngcc: not found
>> make[1]: *** [kernel/bounds.s] Error 127
>> make: *** [prepare0] Error 2
>>
>> .config has CONFIG_CROSS_COMPILE="n"
>
> CONFIG_CROSS_COMPILE is a string option, leave it empty if you are not
> cross compiling.
>
> Michal.
>