From: Julia Lawall <julia.lawall@lip6.fr>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
cocci@systeme.lip6.fr, Nicolas Palix <nicolas.palix@imag.fr>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Michal Marek <michal.lkml@markovi.net>
Subject: Re: [PATCH v3] coccinelle: fix parallel build with CHECK=scripts/coccicheck
Date: Tue, 14 Nov 2017 12:09:29 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1711141208200.2874@hadrien> (raw)
In-Reply-To: <CAK7LNAQ11bf1+=AYVsGfZ+vs-1P0fGCm-2y-qjgKi=KK7-+iSA@mail.gmail.com>
On Tue, 14 Nov 2017, Masahiro Yamada wrote:
> Hi Julia,
>
>
> 2017-11-14 18:49 GMT+09:00 Julia Lawall <julia.lawall@lip6.fr>:
> >> +
> >> + # If -j option is given to Make, scripts/coccicheck runs in parallel.
> >> + # If coccinelle also runs in parallel, it fails because multiple processes
> >> + # try to get access to the same subdirectory that stores stdout/stderr.
> >> + # No need to parallelize coccinelle in this case - this mode takes only
> >> + # one file input.
> >> + NPROC=1
> >
> > Since I am also changing Coccinelle to avoid the problem, maybe it would
> > be better to just remove the explanation sentence (If coccinelle also runs
> > in parallel,...).
> >
> > julia
>
> OK. Which lines are unneeded?
>
> Is it OK to remove all the comments, then just add "NPROC=1"?
How about keeping "# No need to parallelize coccinelle in this case - this
mode takes only one file input."?
But if you think it is obvious, it would be ok to remove it also. Someone
can always do git blame and read the commit message if they have
questions.
julia
next prev parent reply other threads:[~2017-11-14 11:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 9:04 [PATCH v3] coccinelle: fix parallel build with CHECK=scripts/coccicheck Masahiro Yamada
2017-11-14 9:49 ` Julia Lawall
2017-11-14 10:02 ` Masahiro Yamada
2017-11-14 11:09 ` Julia Lawall [this message]
2017-11-14 11:13 ` Masahiro Yamada
2017-11-14 16:52 ` [Cocci] " Luis R. Rodriguez
2017-11-14 16:55 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1711141208200.2874@hadrien \
--to=julia.lawall@lip6.fr \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox