From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Michal Marek <mmarek@suse.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools: Use builtin $(abspath ...) instead of $(shell cd ... && pwd)
Date: Mon, 18 Apr 2016 16:17:26 +0100 (BST) [thread overview]
Message-ID: <alpine.LFD.2.20.1604181609540.28036@eddie.linux-mips.org> (raw)
In-Reply-To: <20160418150535.GA22979@ulmo.ba.sec>
On Mon, 18 Apr 2016, Thierry Reding wrote:
> > > Avoid forking off a shell to resolve the absolute path of the output
> > > directory when make's builtin $(abspath ...) function will do an
> > > adequate job.
> >
> > The abspath function is not available in make 3.80.
>
> Do we really support make 3.80? It was released in 2002 and 3.81
> followed in April 2006. That makes it a decade old now. I'd be surprised
> if anyone was still using it to build recent kernels.
>
> Is there a formal process for increasing the dependencies listed in
> Documentation/Changes? Should I simply make that change as part of this
> patch? Do we need broad approval?
Hmm, what problem are you trying to solve here? Your proposal looks to
me like a gratuitous requirement for users to upgrade their tool (its age
doesn't matter), which is often a burden and in any case requires extra
time which could be used for something else. Don't fix what ain't broke!
Maciej
next prev parent reply other threads:[~2016-04-18 15:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 9:15 [PATCH] tools: Use builtin $(abspath ...) instead of $(shell cd ... && pwd) Thierry Reding
2016-04-18 14:46 ` Michal Marek
2016-04-18 15:05 ` Thierry Reding
2016-04-18 15:17 ` Maciej W. Rozycki [this message]
2016-04-18 15:32 ` Thierry Reding
2017-05-19 2:07 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1604181609540.28036@eddie.linux-mips.org \
--to=macro@linux-mips.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox