* [PATCH] kbuild: silence generated makefile message @ 2011-06-27 21:42 Peter Foley 2011-06-27 23:00 ` Arnaud Lacombe 0 siblings, 1 reply; 8+ messages in thread From: Peter Foley @ 2011-06-27 21:42 UTC (permalink / raw) To: Linux Kernel Mailing List, Linux Kbuild Mailing List, mmarek This patch silences the make -C /usr/src/git O=/usr/src/git/build/. message shown when using the generated makefile in KBUILD_OUTDIR. Signed-off-by: Peter Foley <pefoley2@verizon.net> --- scripts/mkmakefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts/mkmakefile b/scripts/mkmakefile index 5325423..f4642f2 100644 --- a/scripts/mkmakefile +++ b/scripts/mkmakefile @@ -40,7 +40,7 @@ MAKEFLAGS += --no-print-directory all := \$(filter-out all Makefile,\$(MAKECMDGOALS)) all: - \$(MAKE) \$(MAKEARGS) \$(all) + @\$(MAKE) \$(MAKEARGS) \$(all) Makefile:; -- 1.7.5.3 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] kbuild: silence generated makefile message 2011-06-27 21:42 [PATCH] kbuild: silence generated makefile message Peter Foley @ 2011-06-27 23:00 ` Arnaud Lacombe 2011-06-27 23:16 ` Peter Foley 0 siblings, 1 reply; 8+ messages in thread From: Arnaud Lacombe @ 2011-06-27 23:00 UTC (permalink / raw) To: Peter Foley; +Cc: Linux Kernel Mailing List, Linux Kbuild Mailing List, mmarek Hi, On Mon, Jun 27, 2011 at 5:42 PM, Peter Foley <pefoley2@verizon.net> wrote: > > This patch silences the make -C /usr/src/git O=/usr/src/git/build/. > message shown when using the generated makefile in KBUILD_OUTDIR. > I would expect verbose build to show that message. not hides it unconditionally, no ? - Arnaud > Signed-off-by: Peter Foley <pefoley2@verizon.net> > --- > scripts/mkmakefile | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/scripts/mkmakefile b/scripts/mkmakefile > index 5325423..f4642f2 100644 > --- a/scripts/mkmakefile > +++ b/scripts/mkmakefile > @@ -40,7 +40,7 @@ MAKEFLAGS += --no-print-directory > all := \$(filter-out all Makefile,\$(MAKECMDGOALS)) > > all: > - \$(MAKE) \$(MAKEARGS) \$(all) > + @\$(MAKE) \$(MAKEARGS) \$(all) > > Makefile:; > > -- > 1.7.5.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] kbuild: silence generated makefile message 2011-06-27 23:00 ` Arnaud Lacombe @ 2011-06-27 23:16 ` Peter Foley 2011-06-27 23:33 ` [PATCH V2] " Peter Foley 0 siblings, 1 reply; 8+ messages in thread From: Peter Foley @ 2011-06-27 23:16 UTC (permalink / raw) To: Arnaud Lacombe Cc: Peter Foley, Linux Kernel Mailing List, Linux Kbuild Mailing List, mmarek On Mon, 27 Jun 2011, Arnaud Lacombe wrote: > Hi, > > On Mon, Jun 27, 2011 at 5:42 PM, Peter Foley <pefoley2@verizon.net> wrote: > > > > This patch silences the make -C /usr/src/git O=/usr/src/git/build/. > > message shown when using the generated makefile in KBUILD_OUTDIR. > > > I would expect verbose build to show that message. not hides it > unconditionally, no ? > > - Arnaud > Good point, I'll fix that. Thanks, Peter ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH V2] kbuild: silence generated makefile message 2011-06-27 23:16 ` Peter Foley @ 2011-06-27 23:33 ` Peter Foley 2011-07-01 13:47 ` Michal Marek 0 siblings, 1 reply; 8+ messages in thread From: Peter Foley @ 2011-06-27 23:33 UTC (permalink / raw) To: Peter Foley Cc: Arnaud Lacombe, Linux Kernel Mailing List, Linux Kbuild Mailing List, mmarek This patch silences the "make -C /usr/src/git O=/usr/src/git/build/." message shown when using the generated makefile in KBUILD_OUTDIR. Signed-off-by: Peter Foley <pefoley2@verizon.net> --- V2: Show message when V=1 scripts/mkmakefile | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/scripts/mkmakefile b/scripts/mkmakefile index 5325423..ea26f37 100644 --- a/scripts/mkmakefile +++ b/scripts/mkmakefile @@ -30,6 +30,10 @@ PATCHLEVEL = $4 lastword = \$(word \$(words \$(1)),\$(1)) makedir := \$(dir \$(call lastword,\$(MAKEFILE_LIST))) +ifneq (\$(V),1) +Q := @ +endif + MAKEARGS := -C $1 MAKEARGS += O=\$(if \$(patsubst /%,,\$(makedir)),\$(CURDIR)/)\$(patsubst %/,%,\$(makedir)) @@ -40,7 +44,7 @@ MAKEFLAGS += --no-print-directory all := \$(filter-out all Makefile,\$(MAKECMDGOALS)) all: - \$(MAKE) \$(MAKEARGS) \$(all) + \$(Q)\$(MAKE) \$(MAKEARGS) \$(all) Makefile:; -- 1.7.5.3 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH V2] kbuild: silence generated makefile message 2011-06-27 23:33 ` [PATCH V2] " Peter Foley @ 2011-07-01 13:47 ` Michal Marek 2011-07-04 22:55 ` [PATCH V3] " Peter Foley 0 siblings, 1 reply; 8+ messages in thread From: Michal Marek @ 2011-07-01 13:47 UTC (permalink / raw) To: Peter Foley Cc: Arnaud Lacombe, Linux Kernel Mailing List, Linux Kbuild Mailing List On Mon, Jun 27, 2011 at 07:33:54PM -0400, Peter Foley wrote: > > This patch silences the "make -C /usr/src/git O=/usr/src/git/build/." > message shown when using the generated makefile in KBUILD_OUTDIR. > > > Signed-off-by: Peter Foley <pefoley2@verizon.net> > --- > > V2: Show message when V=1 > > scripts/mkmakefile | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/scripts/mkmakefile b/scripts/mkmakefile > index 5325423..ea26f37 100644 > --- a/scripts/mkmakefile > +++ b/scripts/mkmakefile > @@ -30,6 +30,10 @@ PATCHLEVEL = $4 > lastword = \$(word \$(words \$(1)),\$(1)) > makedir := \$(dir \$(call lastword,\$(MAKEFILE_LIST))) > > +ifneq (\$(V),1) > +Q := @ > +endif Please check if V=1 is passed on the commandline and not set in the environmnent, like the toplevel Makefile does: ifeq ("$(origin V)", "command line") ... Michal ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V3] kbuild: silence generated makefile message 2011-07-01 13:47 ` Michal Marek @ 2011-07-04 22:55 ` Peter Foley 2011-07-20 14:06 ` Peter Foley 2011-07-20 15:12 ` Michal Marek 0 siblings, 2 replies; 8+ messages in thread From: Peter Foley @ 2011-07-04 22:55 UTC (permalink / raw) To: Michal Marek Cc: Peter Foley, Arnaud Lacombe, Linux Kernel Mailing List, Linux Kbuild Mailing List This patch silences the "make -C /usr/src/git O=/usr/src/git/build/." message shown when using the generated makefile in KBUILD_OUTDIR. Signed-off-by: Peter Foley <pefoley2@verizon.net> --- V2: Show message when V=1 V3: Check if V=1 comes from the commandline scripts/mkmakefile | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/scripts/mkmakefile b/scripts/mkmakefile index 5325423..0cc0442 100644 --- a/scripts/mkmakefile +++ b/scripts/mkmakefile @@ -30,6 +30,13 @@ PATCHLEVEL = $4 lastword = \$(word \$(words \$(1)),\$(1)) makedir := \$(dir \$(call lastword,\$(MAKEFILE_LIST))) +ifeq ("\$(origin V)", "command line") +VERBOSE := \$(V) +endif +ifneq (\$(VERBOSE),1) +Q := @ +endif + MAKEARGS := -C $1 MAKEARGS += O=\$(if \$(patsubst /%,,\$(makedir)),\$(CURDIR)/)\$(patsubst %/,%,\$(makedir)) @@ -40,7 +47,7 @@ MAKEFLAGS += --no-print-directory all := \$(filter-out all Makefile,\$(MAKECMDGOALS)) all: - \$(MAKE) \$(MAKEARGS) \$(all) + \$(Q)\$(MAKE) \$(MAKEARGS) \$(all) Makefile:; -- 1.7.6 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH V3] kbuild: silence generated makefile message 2011-07-04 22:55 ` [PATCH V3] " Peter Foley @ 2011-07-20 14:06 ` Peter Foley 2011-07-20 15:12 ` Michal Marek 1 sibling, 0 replies; 8+ messages in thread From: Peter Foley @ 2011-07-20 14:06 UTC (permalink / raw) To: Peter Foley Cc: Michal Marek, Arnaud Lacombe, Linux Kernel Mailing List, Linux Kbuild Mailing List On Mon, 4 Jul 2011, Peter Foley wrote: > This patch silences the "make -C /usr/src/git O=/usr/src/git/build/." > message shown when using the generated makefile in KBUILD_OUTDIR. > > Signed-off-by: Peter Foley <pefoley2@verizon.net> > --- > V2: Show message when V=1 > V3: Check if V=1 comes from the commandline > > scripts/mkmakefile | 9 ++++++++- > 1 files changed, 8 insertions(+), 1 deletions(-) > > diff --git a/scripts/mkmakefile b/scripts/mkmakefile > index 5325423..0cc0442 100644 > --- a/scripts/mkmakefile > +++ b/scripts/mkmakefile > @@ -30,6 +30,13 @@ PATCHLEVEL = $4 > lastword = \$(word \$(words \$(1)),\$(1)) > makedir := \$(dir \$(call lastword,\$(MAKEFILE_LIST))) > > +ifeq ("\$(origin V)", "command line") > +VERBOSE := \$(V) > +endif > +ifneq (\$(VERBOSE),1) > +Q := @ > +endif > + > MAKEARGS := -C $1 > MAKEARGS += O=\$(if \$(patsubst /%,,\$(makedir)),\$(CURDIR)/)\$(patsubst > %/,%,\$(makedir)) > > @@ -40,7 +47,7 @@ MAKEFLAGS += --no-print-directory > all := \$(filter-out all Makefile,\$(MAKECMDGOALS)) > > all: > - \$(MAKE) \$(MAKEARGS) \$(all) > + \$(Q)\$(MAKE) \$(MAKEARGS) \$(all) > > Makefile:; > > -- > 1.7.6 > > > Ping? ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V3] kbuild: silence generated makefile message 2011-07-04 22:55 ` [PATCH V3] " Peter Foley 2011-07-20 14:06 ` Peter Foley @ 2011-07-20 15:12 ` Michal Marek 1 sibling, 0 replies; 8+ messages in thread From: Michal Marek @ 2011-07-20 15:12 UTC (permalink / raw) To: Peter Foley Cc: Arnaud Lacombe, Linux Kernel Mailing List, Linux Kbuild Mailing List On Mon, Jul 04, 2011 at 06:55:23PM -0400, Peter Foley wrote: > This patch silences the "make -C /usr/src/git O=/usr/src/git/build/." > message shown when using the generated makefile in KBUILD_OUTDIR. > > Signed-off-by: Peter Foley <pefoley2@verizon.net> > --- > V2: Show message when V=1 > V3: Check if V=1 comes from the commandline Applied to kbuild-2.6.git#kbuild, thanks. Michal ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-07-20 15:12 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-06-27 21:42 [PATCH] kbuild: silence generated makefile message Peter Foley 2011-06-27 23:00 ` Arnaud Lacombe 2011-06-27 23:16 ` Peter Foley 2011-06-27 23:33 ` [PATCH V2] " Peter Foley 2011-07-01 13:47 ` Michal Marek 2011-07-04 22:55 ` [PATCH V3] " Peter Foley 2011-07-20 14:06 ` Peter Foley 2011-07-20 15:12 ` Michal Marek
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox