Re: [PATCH] kbuild: deb-pkg: allow to set package name version

["Guido Günther" <agx@sigxcpu.org>]

Hi,
On Tue, Oct 20, 2026 at 07:16:51PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] kbuild: deb-pkg: broken build symlink in install_kernel_headers()
> --
> 
> commit bc8efaaf9e21748a005be3c75bb9c6c2334ac049
> Author: Guido Günther <agx@sigxcpu.org>
> 
> kbuild: deb-pkg: allow to set package name version
> 
> This commit introduces KDEB_PKGNAMEVERSION in scripts/package/mkdebian to
> allow overriding the version suffix used in the generated Debian binary
> package names instead of always using KERNELRELEASE.

That's true, the script should use ${KERNELRELEASE} when referring to the
kernel version and $version elsewhere. Other parts of the script have
that correct so it's just a:

diff --git a/scripts/package/builddeb b/scripts/package/builddeb
index ba1defc616524..5fdc9ea0dcca4 100755
--- a/scripts/package/builddeb
+++ b/scripts/package/builddeb
@@ -147,8 +147,8 @@ install_kernel_headers () {
 		"${srctree}/scripts/package/install-extmod-build" "${pdir}/usr/src/linux-headers-${version}"
 	fi
 
-	mkdir -p $pdir/lib/modules/$version/
-	ln -s /usr/src/linux-headers-$version $pdir/lib/modules/$version/build
+	mkdir -p $pdir/lib/modules/${KERNELRELEASE}/
+	ln -s /usr/src/linux-headers-$version $pdir/lib/modules/${KERNELRELEASE}/build
 }
 
 install_libc_headers () {

I'll fold that into a v2 after waiting a bit more for other feedback.

Cheers,
 -- Guido