From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out30-130.freemail.mail.aliyun.com ([115.124.30.130]:53454 "EHLO out30-130.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725616AbgFBGki (ORCPT ); Tue, 2 Jun 2020 02:40:38 -0400 Subject: Re: [PATCH] mksysmap: Fix the mismatch of '.L' symbols in System.map References: <1590920904-60002-1-git-send-email-alios_sys_security@linux.alibaba.com> From: AliOS system security Message-ID: Date: Tue, 2 Jun 2020 14:41:49 +0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Masahiro Yamada Cc: Michal Marek , Linux Kbuild mailing list Thanks for your suggestion, I will use my personal account to post a new version later, and amend this comment. On 2020/6/1 19:01, Masahiro Yamada wrote: > On Sun, May 31, 2020 at 7:28 PM AliOS system security > wrote: >> >> When System.map was generated, the kernel used mksysmap to filter the >> kernel symbols, but all the symbols with the second letter 'L' in the >> kernel were filtered out, not just the symbols starting with 'dot + L'. >> >> For example: >> ashimida@ubuntu:~/linux$ cat System.map |grep ' .L' >> ashimida@ubuntu:~/linux$ nm -n vmlinux |grep ' .L' >> ffff0000088028e0 t bLength_show >> ...... >> ffff0000092e0408 b PLLP_OUTC_lock >> ffff0000092e0410 b PLLP_OUTA_lock >> >> I see that in the original patch[1], the original intent should be to >> filter all local symbols starting with '.L', so I wonder if the code >> here may add a '\' before '.L'? > > > You are right, but please avoid the interrogatory sentence. > > Shall I reword as follows? > > > The original intent should be to filter out all local symbols > starting with '.L', so the dot should be escaped. > > > > > >> >> [1]. mksysmap: Add h8300 local symbol pattern >> >> Signed-off-by: AliOS system security >> --- >> scripts/mksysmap | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/scripts/mksysmap b/scripts/mksysmap >> index a35acc0..9aa23d1 100755 >> --- a/scripts/mksysmap >> +++ b/scripts/mksysmap >> @@ -41,4 +41,4 @@ >> # so we just ignore them to let readprofile continue to work. >> # (At least sparc64 has __crc_ in the middle). >> >> -$NM -n $1 | grep -v '\( [aNUw] \)\|\(__crc_\)\|\( \$[adt]\)\|\( .L\)' > $2 >> +$NM -n $1 | grep -v '\( [aNUw] \)\|\(__crc_\)\|\( \$[adt]\)\|\( \.L\)' > $2 >> -- >> 2.7.4 >> > >