linux-kbuild.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Boris Kolpackov <boris@codesynthesis.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
	Luis Chamberlain <mcgrof@kernel.org>
Subject: Re: kconfig: diagnostics cleanups
Date: Wed, 2 Dec 2020 10:06:12 +0200	[thread overview]
Message-ID: <boris.20201202094405@codesynthesis.com> (raw)
In-Reply-To: <CAK7LNAR+OkuHyELBYvcFZpO1b-bKe5rmodtGSuzxPhZsGwTSQA@mail.gmail.com>

Masahiro Yamada <masahiroy@kernel.org> writes:

> We can change them if there is a reason, but I cannot see it in your
> description.

> Boris Kolpackov <boris@codesynthesis.com> wrote:
>
> > 1. Add 'warning' word to $(warning-if) output:

This will make the diagnostics consistent with other places in kconfig
where warnings are issued (see conf_warrning() in confdata.c).


> > 2. Print $(info) output to stderr instead of stdout.

There are two reasons:

1. Error, warning, and info are different diagnostics levels. It was
   surprising to me that the first two go to stderr while info goes
   to stdout. For example, as a user, if I redirect stderr, I would
   naturally expect all the diagnostics to go there.

2. More importantly, stdout is used by terminal-based UI configurators.
   So depending on exactly when $(info) is issued, its output could either
   be clobbered by UI (so the user won't notice it) or it can clobber UI
   (so the user will see broken UI).

  reply	other threads:[~2020-12-02  8:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25 14:38 kconfig: diagnostics cleanups Boris Kolpackov
2020-12-01 14:19 ` Masahiro Yamada
2020-12-02  8:06   ` Boris Kolpackov [this message]
2020-12-21 10:32     ` Masahiro Yamada
2020-12-21 14:05       ` Boris Kolpackov
2020-12-22  5:49         ` Masahiro Yamada
2020-12-22 13:03           ` Boris Kolpackov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=boris.20201202094405@codesynthesis.com \
    --to=boris@codesynthesis.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=mcgrof@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).