From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE52BC83013 for ; Wed, 2 Dec 2020 08:07:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8AE920872 for ; Wed, 2 Dec 2020 08:07:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387884AbgLBIG6 (ORCPT ); Wed, 2 Dec 2020 03:06:58 -0500 Received: from codesynthesis.com ([188.40.148.39]:48400 "EHLO codesynthesis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387654AbgLBIG6 (ORCPT ); Wed, 2 Dec 2020 03:06:58 -0500 Received: from brak.codesynthesis.com (unknown [105.225.210.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by codesynthesis.com (Postfix) with ESMTPSA id AF6415F13B; Wed, 2 Dec 2020 08:06:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codesynthesis.com; s=mail1; t=1606896376; bh=NwSxNJpRG1cLZQrYDrIIx0ik/5TmUkjMipEpsvX/aFA=; h=Date:From:To:Subject:Message-ID:MIME-Version:From; b=tWpRQhYyW5M3szAzJa771WWDXja/qmmMQsmLnUeGzK+VzTatg+dnHW0rHLDDPcJx8 aBazDDiO5l3GiLHfjLVhT/h76Un18ovnamY6k2V3gJWdflYqyap+gjFlOqWZ7F/7Ij Wffv5mgFWQQduhZ90L48orBLY7B29fND+sDQ5wYFlrzZzomZO0hp0xByOGae8Cnfp4 k9Bj8E1TYuK0oU8aLbdDtRIzOnv9VEyQ1fkBKvFajXkIcDdFqiCWj6poyXUVyYUkA0 WQaf8IUeCi9XqjTt1hRSaP2a2IPssDEm+yqivHqDNC3wboEhIvD36UdCtp65DBs1w/ jUlGMU8LIlLbQ== Received: by brak.codesynthesis.com (Postfix, from userid 1000) id 8ED861A800C5; Wed, 2 Dec 2020 10:06:12 +0200 (SAST) Date: Wed, 2 Dec 2020 10:06:12 +0200 From: Boris Kolpackov To: Masahiro Yamada Cc: Linux Kbuild mailing list , Luis Chamberlain Subject: Re: kconfig: diagnostics cleanups Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Code Synthesis User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org Masahiro Yamada writes: > We can change them if there is a reason, but I cannot see it in your > description. > Boris Kolpackov wrote: > > > 1. Add 'warning' word to $(warning-if) output: This will make the diagnostics consistent with other places in kconfig where warnings are issued (see conf_warrning() in confdata.c). > > 2. Print $(info) output to stderr instead of stdout. There are two reasons: 1. Error, warning, and info are different diagnostics levels. It was surprising to me that the first two go to stderr while info goes to stdout. For example, as a user, if I redirect stderr, I would naturally expect all the diagnostics to go there. 2. More importantly, stdout is used by terminal-based UI configurators. So depending on exactly when $(info) is issued, its output could either be clobbered by UI (so the user won't notice it) or it can clobber UI (so the user will see broken UI).