linux-kbuild.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Nathan Chancellor <nathan@kernel.org>,
	Jean Delvare <jdelvare@suse.de>,
	Linux Documentation <linux-doc@vger.kernel.org>
Cc: linux-kbuild@vger.kernel.org,
	Nicolas Schier <nicolas.schier@linux.dev>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Subject: Re: [PATCH] Makefile: Let kernel-doc.py use PYTHON3 override
Date: Mon, 3 Nov 2025 11:00:51 -0800	[thread overview]
Message-ID: <c0e4a0b0-b7c9-491b-ada3-74945fb2e3d9@infradead.org> (raw)
In-Reply-To: <20251103185609.GB672460@ax162>

Hi,

On 11/3/25 10:56 AM, Nathan Chancellor wrote:
> On Mon, Nov 03, 2025 at 01:14:19PM +0100, Jean Delvare wrote:
>> It is possible to force a specific version of python to be used when
>> building the kernel by passing PYTHON3= on the make command line.
>> However kernel-doc.py is currently called with python3 hard-coded and
>> thus ignores this setting.
>>
>> Use PYTHON3 to call kernel-doc.py so that the desired version of
>> python is used.
>>
>> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> 
> I see one use of KERNELDOC in tools/docs/sphinx-build-wrapper that would
> appear to break with this change? Does it matter? I am not familiar with
> the docs build. Otherwise, this seems like the correct thing to do.

I think there has been some discussion of these matters on the linux-doc
mailing list (adding it here).

>> ---
>>  Makefile |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- linux-6.17.orig/Makefile
>> +++ linux-6.17/Makefile
>> @@ -460,7 +460,7 @@ HOSTPKG_CONFIG	= pkg-config
>>  
>>  # the KERNELDOC macro needs to be exported, as scripts/Makefile.build
>>  # has a logic to call it
>> -KERNELDOC       = $(srctree)/scripts/kernel-doc.py
>> +KERNELDOC       = $(PYTHON3) $(srctree)/scripts/kernel-doc.py
>>  export KERNELDOC
>>  
>>  KBUILD_USERHOSTCFLAGS := -Wall -Wmissing-prototypes -Wstrict-prototypes \
>>
>>
>> -- 
>> Jean Delvare
>> SUSE L3 Support
> 

-- 
~Randy


  reply	other threads:[~2025-11-03 19:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-03 12:14 [PATCH] Makefile: Let kernel-doc.py use PYTHON3 override Jean Delvare
2025-11-03 18:56 ` Nathan Chancellor
2025-11-03 19:00   ` Randy Dunlap [this message]
2025-11-07 10:13     ` Mauro Carvalho Chehab
2025-11-07 18:26       ` Jean Delvare
2025-11-07 20:45         ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0e4a0b0-b7c9-491b-ada3-74945fb2e3d9@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=jdelvare@suse.de \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=mchehab+huawei@kernel.org \
    --cc=nathan@kernel.org \
    --cc=nicolas.schier@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).