Linux kbuild/kconfig development
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Alexey Dobriyan <adobriyan@gmail.com>,
	Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] menuconfig: delete shadows, reclaim vertical space
Date: Sat, 4 Mar 2023 09:56:08 -0800	[thread overview]
Message-ID: <d01112c2-b5a4-4aa3-4ee7-711abc9da079@infradead.org> (raw)
In-Reply-To: <94a94ef4-9d55-4293-8363-3c0243eceae1@p183>

Hi,

On 3/4/23 08:55, Alexey Dobriyan wrote:
> Menuconfig has lots of vertical space wasted: on my system there are
> 17 lines of useful information about config options and 14 lines of
> useless fluff: legend, horizontal separators and shadows.
> 
> Sitation is even worse on smaller terminals because fixed vertical lines
> do not go away, but config option lines do decreasing informational
> density even more.
> 
> Delete shadows and increase menu size to reclaim vertical space.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
> 
>  scripts/kconfig/lxdialog/checklist.c |    2 --
>  scripts/kconfig/lxdialog/dialog.h    |    1 -
>  scripts/kconfig/lxdialog/inputbox.c  |    2 --
>  scripts/kconfig/lxdialog/menubox.c   |    6 ++----
>  scripts/kconfig/lxdialog/textbox.c   |    2 --
>  scripts/kconfig/lxdialog/util.c      |   22 ----------------------
>  scripts/kconfig/lxdialog/yesno.c     |    2 --
>  7 files changed, 2 insertions(+), 35 deletions(-)
> 

This patch works for me, but since the right side shadow is
also being removed, the one column (width) that it had
occupied might as well be used (reclaimed) instead of just
going to waste.

Thanks.
-- 
~Randy

  parent reply	other threads:[~2023-03-04 17:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-04 16:55 [PATCH 1/2] menuconfig: delete shadows, reclaim vertical space Alexey Dobriyan
2023-03-04 16:56 ` [PATCH 2/2] menuconfig: reclaim 1 more vertical line Alexey Dobriyan
2023-03-04 17:52   ` Randy Dunlap
2023-03-04 18:53     ` Alexey Dobriyan
2023-03-04 17:56 ` Randy Dunlap [this message]
2023-03-04 18:54   ` [PATCH 1/2] menuconfig: delete shadows, reclaim vertical space Alexey Dobriyan
2023-03-05  6:19     ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d01112c2-b5a4-4aa3-4ee7-711abc9da079@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=adobriyan@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox