Re: [PATCH v4 01/16] module: Take const arg in validate_section_offset

[Daniel Gomez <da.gomez@samsung.com>]

On 9/24/2024 11:19 PM, Matthew Maurer wrote:
> `validate_section_offset` doesn't modify the info passed in. Make this
> clear by adjusting the type signature.
> 
> Signed-off-by: Matthew Maurer <mmaurer@google.com>
> ---
>   kernel/module/main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/module/main.c b/kernel/module/main.c
> index 49b9bca9de12..1a2dd52147ba 100644
> --- a/kernel/module/main.c
> +++ b/kernel/module/main.c
> @@ -1645,7 +1645,7 @@ bool __weak module_exit_section(const char *name)
>   	return strstarts(name, ".exit");
>   }
>   
> -static int validate_section_offset(struct load_info *info, Elf_Shdr *shdr)
> +static int validate_section_offset(const struct load_info *info, Elf_Shdr *shdr)
>   {
>   #if defined(CONFIG_64BIT)
>   	unsigned long long secend;


The cover letter is missing a From/Cc to the linux-modules list. So I 
was missing the context here. Looking at lore I found it here:

https://lore.kernel.org/asahi/20240924212024.540574-1-mmaurer@google.com/

Can you add linux-modules list in case there's a next revision?

Also, the cover letter is missing a full changelog other than a 
reference to the previous discussions and to the last changes.

Daniel