From: David Hunter <david.hunter.linux@gmail.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
shuah@kernel.org, javier.carrasco.cruz@gmail.com
Subject: Re: [PATCH 5/7] linux-kbuild: fix: implement choice for kconfigs
Date: Thu, 10 Oct 2024 16:06:11 -0400 [thread overview]
Message-ID: <dd2d6338-b763-48ad-be9c-aed7107b201d@gmail.com> (raw)
In-Reply-To: <CAK7LNAQ8D4OVT81iTVs8jjrBXX6Zgwc+VJ_vb7hb4J-vCZZN=g@mail.gmail.com>
On 9/23/24 23:46, Masahiro Yamada wrote:
>
> This is ugly.
> Please do not use the temp file.
>
Understood. I found a way to do it that is much more in line with the
style of the script and it avoids using the temp file. Oddly enough it
involves changing less lines of code as well. I will be submitting the
changes soon. Right now, I am just finishing up the change logs for all
the patches.
My question here is "Is there a general rule as to why the first version
was bad?" For example, is it considered bad practice to make temporary
files?
Thanks,
David Hunter
next prev parent reply other threads:[~2024-10-10 20:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 17:11 David Hunter
2024-09-13 17:11 ` [PATCH 1/7] linux-kbuild: fix: config option can be bool David Hunter
2024-09-24 2:55 ` Masahiro Yamada
2024-10-10 19:46 ` David Hunter
2024-10-14 14:22 ` David Hunter
2024-09-13 17:11 ` [PATCH 2/7] linux-kbuild: fix: missing variable operator David Hunter
2024-09-24 3:04 ` Masahiro Yamada
2024-10-14 14:26 ` David Hunter
2024-09-13 17:11 ` [PATCH 3/7] linux-kbuild: fix: ensure all defaults are tracked David Hunter
2024-09-24 3:06 ` Masahiro Yamada
2024-10-14 14:27 ` David Hunter
2024-09-13 17:11 ` [PATCH 4/7] linux-kbuild: fix: ensure selected configs were turned on in original David Hunter
2024-09-24 3:45 ` Masahiro Yamada
2024-10-14 14:38 ` David Hunter
2024-09-13 17:12 ` [PATCH 5/7] linux-kbuild: fix: implement choice for kconfigs David Hunter
2024-09-24 3:46 ` Masahiro Yamada
2024-10-10 20:06 ` David Hunter [this message]
2024-10-10 20:29 ` David Hunter
2024-10-14 14:39 ` David Hunter
2024-09-13 17:12 ` [PATCH 6/7] linux-kbuild: fix: configs with defaults do not need a prompt David Hunter
2024-09-24 4:08 ` Masahiro Yamada
2024-10-14 14:41 ` David Hunter
2024-09-13 17:12 ` [PATCH 7/7] linux-kbuild: fix: process config options set to "y" David Hunter
2024-09-24 4:21 ` Masahiro Yamada
2024-10-10 20:47 ` David Hunter
2024-10-14 14:42 ` David Hunter
2024-09-13 20:39 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd2d6338-b763-48ad-be9c-aed7107b201d@gmail.com \
--to=david.hunter.linux@gmail.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox