Re: [PATCH] Makefile: allow modules_install if CONFIG_MODULES=n

[Jonas Zeiger <jonas.zeiger@talpidae.net>]

On 2020-05-31 20:16, Masahiro Yamada wrote:
> On Thu, May 28, 2020 at 1:44 PM Jonas Zeiger 
> <jonas.zeiger@talpidae.net> wrote:
>> 
>> Many applications check for available kernel features via:
>> 
>>   * /proc/modules (loaded modules, present if CONFIG_MODULES=y)
>>   * $(MODLIB)/modules.builtin (builtin modules)
>> 
>> They fail to detect features if the kernel was built with
>> CONFIG_MODULES=n
>> and modules.builtin isn't installed.
>> 
>> Therefore, allow the Makefile's modules_install target to be used
>> always.
>> 
>> Tested Makefile targets with different CONFIG_MODULES states:
>> 
>>   * (CONFIG_MODULES=n) modules_install: install modules.builtin etc.
>>   * (CONFIG_MODULES=y) modules_install: produce same result as before
>>   * (CONFIG_MODULES=y) modules_install: still fail if no modules.order
>>   * (CONFIG_MODULES=y) modules: build modules, as before
>>   * (CONFIG_MODULES=n) modules: still fail and warn
>> 
>> Signed-off-by: Jonas Zeiger <jonas.zeiger@talpidae.net>
> 
> 
> Maybe, module.builtin and module.builtin.modinfo should be
> installed by 'make install' because they are byproducts of vmlinux.

Yes, thank you for this suggestion.

I will submit a new patch.