From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pfout8-smtp.messagingengine.com (fout8-smtp.messagingengine.com [103.168.172.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC21C18BC1D; Tue, 3 Sep 2024 17:55:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.151 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725386108; cv=none; b=V7E68ItXxCZMJodOgPu7Aw/qgmaARYeUw3kDRORqOmSTHCIbFQOHCujUFmt1AfT1XtPEKLpC70hTEzqlKcg5DzCTvjHqVAU/I+Vi42QzfPWrXUi2YfpPKxnyK0xywXqLfNRILQud+wOcOQGgaO0xJlYhX1cUH78CAAUobkVWf8U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725386108; c=relaxed/simple; bh=37evq7OXVd1o3LryU5tBnSFjiHmbXWuaq7kxeMtQ1tU=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=mZ5pvlYWn1UblO1TBrwyGvXfsQ5GKt8/sSiMW0WLuxS1a/rn/TvM8oPHOm9WSSUgT2bsy5Mz85wKD6Yn/Y/9OEFM9puLv+vMsUDjLMD54BmZyg/TXiRsIbDR/ugnGjqsMdn2uOi1eDxflmhwof4twx9TG01RVTB6Do2OZfnZ/hU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=flygoat.com; spf=pass smtp.mailfrom=flygoat.com; dkim=pass (2048-bit key) header.d=flygoat.com header.i=@flygoat.com header.b=Moo2wn3Y; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=OKci0VBm; arc=none smtp.client-ip=103.168.172.151 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=flygoat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flygoat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flygoat.com header.i=@flygoat.com header.b="Moo2wn3Y"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="OKci0VBm" Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfout.phl.internal (Postfix) with ESMTP id F1D7713804C2; Tue, 3 Sep 2024 13:55:05 -0400 (EDT) Received: from phl-imap-12 ([10.202.2.86]) by phl-compute-05.internal (MEProxy); Tue, 03 Sep 2024 13:55:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flygoat.com; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1725386105; x=1725472505; bh=37evq7OXVd1o3LryU5tBnSFjiHmbXWuaq7kxeMtQ1tU=; b= Moo2wn3Y6WCs1URJbxvK5gtu1ZToa7Zni3vxmE7obzQyRJn20r6WyvC8N1mtKBzr KZH/LoPhTOQpCggk3Hok4R0oPTHD5mjQLQ7ln6evNRvneQXl5lg/FiXdUQnh3YoL 42QIvYA0qO6zCJYrSAciDBmHEAMC3gDywagFgeL9mxAe1mpxxbaK8IYYQe5p+wu2 nJarnfvLVpgt1/o1lZPsJwbp4kPOLq79yjxC2wQB5x0R5p3N9t8ZyowTYp7vmP38 Ov+iZ6ciNYzuPDf7vBjw8HnA1mYyM9wjYWI1iy6YAAUYuu2ag41m0O8chUfAjGZI WLH4wdpI0r95308Z3B6E5A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1725386105; x= 1725472505; bh=37evq7OXVd1o3LryU5tBnSFjiHmbXWuaq7kxeMtQ1tU=; b=O Kci0VBmFXv6/+sVXOuqU4tP/J/aP5vCYWtQclpXo5zcw21hK17LVCpTsH5kn8wAS A0cybhaOCzrd96lcRRTJqFvzKZGnOlpEc/EWR8kMCs2R6r6kx7arFurMeIwUoNdF qdwj4TRrKYTWODDxZsWXPOx6/4UogwJNaprgkUJ99NWgNhESG/Skng6y9q9Wg6ej JcIVtpedGrkB5XlsPA9SkJDDTEEICY/ZMcUZr+OBroPFAA2fALELkFc/mYSvDNsL SKXTkfs8wuTSabjS6kTXVNhg42RoxTiAZYvPSZlJUwkpBMZE7cyHz05bMMuisl9R KnGcLM/jbbVK2hkd1FEGQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudehhedguddukecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefoggffhffvvefkjghfufgtgfesthhqredtredt jeenucfhrhhomhepfdflihgrgihunhcujggrnhhgfdcuoehjihgrgihunhdrhigrnhhgse hflhihghhorghtrdgtohhmqeenucggtffrrghtthgvrhhnpeejheefuddvtdfggfdvffek teehhfelgfdvvedvkeeuffefkeehheegvefhveetjeenucevlhhushhtvghrufhiiigvpe dunecurfgrrhgrmhepmhgrihhlfhhrohhmpehjihgrgihunhdrhigrnhhgsehflhihghho rghtrdgtohhmpdhnsggprhgtphhtthhopeegtddpmhhouggvpehsmhhtphhouhhtpdhrtg hpthhtohepsghpsegrlhhivghnkedruggvpdhrtghpthhtohepthhssghoghgvnhgusegr lhhphhgrrdhfrhgrnhhkvghnrdguvgdprhgtphhtthhopehmrghrkhdrrhhuthhlrghnug esrghrmhdrtghomhdprhgtphhtthhopegrnhhtohhnrdhivhgrnhhovhestggrmhgsrhhi ughgvghgrhgvhihsrdgtohhmpdhrtghpthhtohepnhhitgholhgrshesfhhjrghslhgvrd gvuhdprhgtphhtthhopehgrghrhiesghgrrhihghhuohdrnhgvthdprhgtphhtthhopegr lhgvgidrghgrhihnohhrsehgmhgrihhlrdgtohhmpdhrtghpthhtohepsghoqhhunhdrfh gvnhhgsehgmhgrihhlrdgtohhmpdhrtghpthhtohepmhhighhuvghlrdhojhgvuggrrdhs rghnughonhhishesghhmrghilhdrtghomh X-ME-Proxy: Feedback-ID: ifd894703:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 23E241C207BB; Tue, 3 Sep 2024 13:55:05 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kbuild@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Tue, 03 Sep 2024 18:54:44 +0100 From: "Jiaxun Yang" To: "Miguel Ojeda" Cc: "Masahiro Yamada" , "Nathan Chancellor" , "Nicolas Schier" , "Richard Weinberger" , "Anton Ivanov" , "Johannes Berg" , "Thomas Gleixner" , "Ingo Molnar" , "Borislav Petkov" , "Dave Hansen" , x86@kernel.org, "H. Peter Anvin" , "Miguel Ojeda" , "Alex Gaynor" , "Wedson Almeida Filho" , "Boqun Feng" , "Gary Guo" , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , "Benno Lossin" , "Andreas Hindborg" , "Alice Ryhl" , "Thomas Bogendoerfer" , "Steven Rostedt" , "Masami Hiramatsu" , "Mark Rutland" , "Jonathan Corbet" , "Alex Shi" , "Yanteng Si" , "Nick Desaulniers" , "Bill Wendling" , "Justin Stitt" , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-um@lists.infradead.org, rust-for-linux@vger.kernel.org, "linux-mips@vger.kernel.org" , linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, llvm@lists.linux.dev Message-Id: In-Reply-To: References: <20240903-mips-rust-v1-0-0fdf0b2fd58f@flygoat.com> <20240903-mips-rust-v1-2-0fdf0b2fd58f@flygoat.com> Subject: Re: [PATCH 2/3] MIPS: Rename mips_instruction type to workaround bindgen issue Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable =E5=9C=A82024=E5=B9=B49=E6=9C=883=E6=97=A5=E4=B9=9D=E6=9C=88 =E4=B8=8B=E5= =8D=886:43=EF=BC=8CMiguel Ojeda=E5=86=99=E9=81=93=EF=BC=9A > On Tue, Sep 3, 2024 at 7:15=E2=80=AFPM Jiaxun Yang wrote: >> >> We have a union and a type both named after mips_instruction, >> rust bindgen is not happy with this kind of naming alias. > > For this sort of thing, you may be able to add it to the block list at > `rust/bindgen_parameters`, so that you don't need to change any C > code. Thanks for the tip! Given that it's trivial to avoid in C code I'd still prefer to fix the a= ctual code.=20 Thanks > > I hope that helps! > > Cheers, > Miguel --=20 - Jiaxun