From: Petr Pavlu <petr.pavlu@suse.com>
To: Borislav Petkov <bp@alien8.de>, Ard Biesheuvel <ardb+git@google.com>
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
x86@kernel.org, Ard Biesheuvel <ardb@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH v2 4/4] x86: Get rid of Makefile.postlink
Date: Wed, 12 Mar 2025 13:35:58 +0100 [thread overview]
Message-ID: <f17b5886-8b46-4edb-9f61-7ff9b60d1b5e@suse.com> (raw)
In-Reply-To: <20250311111745.GDZ9Ab2f6-iHLXmRra@fat_crate.local>
On 3/11/25 12:17, Borislav Petkov wrote:
> + Petr for 9d9173e9ceb6
>
> @Petr, you can find the whole thread on lore.
>
> On Tue, Mar 11, 2025 at 12:06:21PM +0100, Ard Biesheuvel wrote:
>> From: Ard Biesheuvel <ardb@kernel.org>
>>
>> Instead of generating the vmlinux.relocs file (needed by the
>> decompressor build to construct the KASLR relocation tables) as a
>> vmlinux postlink step, which is dubious because it depends on data that
>> is stripped from vmlinux before the build completes, generate it from
>> vmlinux.unstripped, which has been introduced specifically for this
>> purpose.
>>
>> This ensures that each artifact is rebuilt as needed, rather than as a
>> side effect of another build rule.
>>
>> This effectively reverts commit
>>
>> 9d9173e9ceb6 ("x86/build: Avoid relocation information in final vmlinux")
>>
>> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
For what it's worth, the changes look to me as an improvement over the
previous implementation.
--
Thanks,
Petr
next prev parent reply other threads:[~2025-03-12 12:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 11:06 [PATCH v2 0/4] x86/build: Get rid of vmlinux postlink step Ard Biesheuvel
2025-03-11 11:06 ` [PATCH v2 1/4] Kbuild/link-vmlinux.sh: Make output file name configurable Ard Biesheuvel
2025-03-11 11:06 ` [PATCH v2 2/4] Kbuild: Introduce Kconfig symbol for linking vmlinux with relocations Ard Biesheuvel
2025-03-11 11:06 ` [PATCH v2 3/4] Kbuild: Create intermediate vmlinux build with relocations preserved Ard Biesheuvel
2025-03-13 9:21 ` kernel test robot
2025-03-13 9:34 ` Ard Biesheuvel
2025-03-13 10:18 ` Ard Biesheuvel
2025-03-13 10:29 ` Masahiro Yamada
2025-03-18 8:17 ` Heiko Carstens
2025-03-18 8:27 ` Ard Biesheuvel
2025-03-18 16:26 ` Masahiro Yamada
2025-04-30 16:03 ` Conor Dooley
2025-04-30 16:29 ` Palmer Dabbelt
2025-03-11 11:06 ` [PATCH v2 4/4] x86: Get rid of Makefile.postlink Ard Biesheuvel
2025-03-11 11:17 ` Borislav Petkov
2025-03-12 12:35 ` Petr Pavlu [this message]
2025-03-13 2:08 ` Masahiro Yamada
2025-03-13 7:47 ` Ard Biesheuvel
2025-03-15 7:09 ` [PATCH v2 0/4] x86/build: Get rid of vmlinux postlink step Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f17b5886-8b46-4edb-9f61-7ff9b60d1b5e@suse.com \
--to=petr.pavlu@suse.com \
--cc=ardb+git@google.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mingo@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox