From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B47C4C433EF for ; Fri, 8 Jul 2022 21:22:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240468AbiGHVWp (ORCPT ); Fri, 8 Jul 2022 17:22:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231845AbiGHVWo (ORCPT ); Fri, 8 Jul 2022 17:22:44 -0400 Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFE03A0275 for ; Fri, 8 Jul 2022 14:22:41 -0700 (PDT) Received: by mail-io1-xd36.google.com with SMTP id h200so133084iof.9 for ; Fri, 08 Jul 2022 14:22:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=K2R5p2Dupobo52J5LKvzicluXJB27VeNuo+pciX7wtY=; b=R+jSOCf66H2Wpu3B4G2Nl4FC1cwmfghiGnaxPLpsZ+5fTMrp7f89L13mZrLMMT38ak fG17da3ItIJOW4nIG+91e/JumTH65V7EPsPLaLJA0xHKWuCFM6wJO+fmmncjoFIpNAik PBGFQDsu0/+DLpPbs4ft5LYoPYQeH5I8UBf5Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=K2R5p2Dupobo52J5LKvzicluXJB27VeNuo+pciX7wtY=; b=x0lMP5NqJXcINi6i/HfsgrAS8gIw+Navft4Q1pq9+kTiVoUBEM+UZApq8aVJ/MIPmD P8E1Yr+ORB+AkBRnebKVGpmiC4EiL9AXMZUPM/r+X/4KxlC+WNS93jJWFygMLowhDZDz QYBkDcasV/GuBPexg376diK9t+amBsqdA3kM9PhIJjcTqhzHfuYwgBCk1EMyehUfwVB9 tteXhHugtS/5CPS1kMdbcIR5FKC7xXmgnc85PjkPlP9U1B/KiRgewn1u06pqwKcQk7tB vcLYML4ctkzqBfB9xP50cBi+DxMLgHEMqN9+Jj9iiEoLOZoJJXb8g+Ga/LN93Vx7MOss ZuSw== X-Gm-Message-State: AJIora+RUBw8igbbwbYMToogI2PUbTfooFZoRgjxXaoOq5494a7GFRBn 1x9cGAGY+bb+/HmwWXvGd5i1/A== X-Google-Smtp-Source: AGRyM1sBGtjnfcBKedHSlWE+lXBNa3rRq515LuRvzMUrGjspYvOQVTMnVYCSURkGMgq54Y0XPQgGxA== X-Received: by 2002:a5e:c016:0:b0:675:398:4713 with SMTP id u22-20020a5ec016000000b0067503984713mr3076239iol.149.1657315361067; Fri, 08 Jul 2022 14:22:41 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id q4-20020a5d87c4000000b0066961821575sm19918898ios.34.2022.07.08.14.22.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Jul 2022 14:22:40 -0700 (PDT) Subject: Re: [PATCH v6 3/4] kunit: Taint the kernel when KUnit tests are run To: Daniel Latypov Cc: David Gow , Andrew Morton , Brendan Higgins , "Guilherme G . Piccoli" , Sebastian Reichel , John Ogness , Joe Fradley , Luis Chamberlain , Nathan Chancellor , kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, Andy Shevchenko , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Jani Nikula , Lucas De Marchi , Aaron Tomlin , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, Michal Marek , Nick Desaulniers , Jonathan Corbet , linux-kbuild@vger.kernel.org, Greg KH , Masahiro Yamada , Kees Cook , Shuah Khan References: <20220708044847.531566-1-davidgow@google.com> <20220708044847.531566-3-davidgow@google.com> From: Shuah Khan Message-ID: Date: Fri, 8 Jul 2022 15:22:39 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org On 7/8/22 3:00 PM, Daniel Latypov wrote: > On Fri, Jul 8, 2022 at 1:22 PM Shuah Khan wrote: >> >> On 7/7/22 10:48 PM, David Gow wrote: >>> Make KUnit trigger the new TAINT_TEST taint when any KUnit test is run. >>> Due to KUnit tests not being intended to run on production systems, and >>> potentially causing problems (or security issues like leaking kernel >>> addresses), the kernel's state should not be considered safe for >>> production use after KUnit tests are run. >>> >>> This both marks KUnit modules as test modules using MODULE_INFO() and >>> manually taints the kernel when tests are run (which catches builtin >>> tests). >>> >>> Acked-by: Luis Chamberlain >>> Tested-by: Daniel Latypov >>> Reviewed-by: Brendan Higgins >>> Signed-off-by: David Gow >>> --- >>> >>> No changes since v5: >>> https://lore.kernel.org/linux-kselftest/20220702040959.3232874-3-davidgow@google.com/ >>> >>> No changes since v4: >>> https://lore.kernel.org/linux-kselftest/20220701084744.3002019-3-davidgow@google.com/ >>> >> >> David, Brendan, Andrew, >> >> Just confirming the status of these patches. I applied v4 1/3 and v4 3/4 >> to linux-kselftest kunit for 5.20-rc1. >> I am seeing v5 and v6 now. Andrew applied v5 looks like. Would you like >> me to drop the two I applied? Do we have to refresh with v6? > > Just noting here that there'll be a merge conflict between this patch > (3/4) and some other patches lined up to go through the kunit tree: > https://patchwork.kernel.org/project/linux-kselftest/patch/20220625050838.1618469-2-davidgow@google.com/ > > Not sure how we want to handle that. > I can go drop the two patches and have Andrew carry the series through mm tree. thanks, -- Shuah