Re: [Resend PATCH] package: Makefile: fix perf target bug

matt mooney
2011-05-12T21:38:17Z

On Thu, May 12, 2011 at 2:20 PM, Michal Marek <mmarek@suse.cz> wrote:
> On 12.5.2011 23:07, matt mooney wrote:
>> 2011/5/12 Michal Marek <mmarek@suse.cz>:
>>> On 12.5.2011 20:25, mfmooney@gmail.com wrote:
>>>> diff --git a/scripts/package/Makefile b/scripts/package/Makefile
>>>> index 1b7eaea..a32dc2d 100644
>>>> --- a/scripts/package/Makefile
>>>> +++ b/scripts/package/Makefile
>>>> @@ -118,10 +118,14 @@ perf-tar=perf-$(KERNELVERSION)
>>>>
>>>>  quiet_cmd_perf_tar = TAR
>>>>        cmd_perf_tar = \
>>>> -git archive --prefix=$(perf-tar)/ HEAD^{tree}                       \
>>>> -     $$(cat $(srctree)/tools/perf/MANIFEST) -o $(perf-tar).tar;  \
>>>> +git --git-dir=$(srctree)/.git --work-tree=$(srctree)                \
>>>
>>> Neither git archive not git rev-parse need the work tree, --git-dir=..
>>> is sufficient.
>>
>> Are you sure?
>
> Yes.
> $ cd /tmp
> $ git --git-dir=$HOME/linux-2.6/.git rev-parse HEAD
> e0a04b11e4059cab033469617c2a3ce2d8cab416
>

You are right about that command, but it doesn't use the source tree.
Do a git --git-dir=$HOME/linux-2.6/.git status from /tmp and see what
happens.

So do you want me to send a new patch without --work-tree= in git rev-parse?

-matt

--
GPG-Key: 9AFE00EA