Re: [PATCH v2] package: Makefile: fix perf target bug

WANG Cong
2011-05-13T05:22:35Z

On Thu, 12 May 2011 17:09:03 -0700, mfmooney wrote:

> From: matt mooney <mfm@muteddisk.com>
>
> Specify --git-dir and --work-tree when building perf targets to allow
> out-of-tree builds using O=<build-dir>.
>
> The cat command had to be changed to allow proper file name expansion of
> the files listed in MANIFEST.
>
> Signed-off-by: matt mooney <mfm@muteddisk.com> ---
> Okay, so I decided to just go ahead and send this. It removes the
> --work-tree option from the git rev-parse command. I did test it the way
> you said, without --work-tree on either statement, but the git archive
> command fails in that case.
>

Looks like `git rev-parse` only needs the data in .git to work fine,
so this patch looks good to me,

Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>

BTW, I think you need to Cc Ingo and Peter for perf changes.

Thanks.