From: ebiederm@xmission.com (Eric W. Biederman)
To: Michal Marek <mmarek@suse.cz>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Arnaud Lacombe <lacombar@gmail.com>,
linux-kbuild@vger.kernel.org
Subject: [PATCH] kbuild: Add error handling to KCONFIG_ALL_CONFIG
Date: Tue, 24 Apr 2012 04:57:39 -0700 [thread overview]
Message-ID: <m1aa21nxzg.fsf_-_@fess.ebiederm.org> (raw)
In-Reply-To: <4F96705C.5030901@suse.cz> (Michal Marek's message of "Tue, 24 Apr 2012 11:20:28 +0200")
- Only try to read the file specified if KCONFIG_ALL_CONFIG is set to
something other than the empty string.
- Don't use stat to check the name passed to conf_read_simple so that
zconf_fopen can find the file in the current directory or in SRCTREE
removing a extremely confusing failure mode, where KCONFIG_ALL_CONFIG
was not interpreted with respect to the directory make was called in.
- If conf_read_simple fails complain clearly and stop processing.
Allowing the simple discovery and debugging of command line typos.
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
scripts/kconfig/conf.c | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
index 28910ea..af6a2db 100644
--- a/scripts/kconfig/conf.c
+++ b/scripts/kconfig/conf.c
@@ -579,8 +579,13 @@ int main(int ac, char **av)
case alldefconfig:
case randconfig:
name = getenv("KCONFIG_ALLCONFIG");
- if (name && !stat(name, &tmpstat)) {
- conf_read_simple(name, S_DEF_USER);
+ if (name && name[0] != '\0') {
+ if (conf_read_simple(name, S_DEF_USER)) {
+ fprintf(stderr,
+ _("*** Can't read seed configuration \"%s\"!\n"),
+ name);
+ exit(1);
+ }
break;
}
switch (input_mode) {
--
1.7.2.5
next prev parent reply other threads:[~2012-04-24 13:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 0:59 [PATCH] kbuld: Implement oldmodconfig Eric W. Biederman
2012-04-24 9:20 ` Michal Marek
2012-04-24 10:37 ` Eric W. Biederman
2012-04-24 11:57 ` Eric W. Biederman [this message]
2012-04-24 12:33 ` [PATCH] kbuild: Add error handling to KCONFIG_ALL_CONFIG Michal Marek
2012-04-24 12:54 ` Eric W. Biederman
2012-04-24 13:37 ` Michal Marek
2012-04-26 8:51 ` Eric W. Biederman
2012-05-04 22:24 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1aa21nxzg.fsf_-_@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox