From: sashiko-bot@kernel.org
To: "Thomas Weißschuh" <linux@weissschuh.net>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nicolas Schier" <nsc@kernel.org>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: [PATCH 3/3] kbuild: don't print DESCEND messages from tools/ build
Date: Tue, 03 Nov 2026 05:56:00 +0000 [thread overview]
Message-ID: <sashiko-outbox-194603@kernel.org> (raw)
In-Reply-To: <20261102-kbuild-descend-spam-v1-3-caff4f840cb7@weissschuh.net>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] kbuild: missing QUIET_DESCEND=$(Q) in explicit tools/bootconfig target
--
commit 7691301f76c95de2969936070a6b66297111591a
Author: Thomas Weißschuh <linux@weissschuh.net>
kbuild: don't print DESCEND messages from tools/ build
This commit passes QUIET_DESCEND=$(Q) to the tools/ sub-make invoked by the
tools/% pattern rule in the top-level Makefile so that Kbuild suppresses
the DESCEND messages emitted by the tools/ build system by default.
> diff --git a/Makefile b/Makefile
> index d73f2bbd3b93d..2bfe786bc2843 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1637,7 +1637,7 @@ endif
>
> tools/%: FORCE
> $(Q)mkdir -p $(objtree)/tools
> - $(Q)$(MAKE) O=$(abspath $(objtree)) subdir=tools -C $(srctree)/tools/ $*
> + $(Q)$(MAKE) O=$(abspath $(objtree)) QUIET_DESCEND=$(Q) subdir=tools -C $(srctree)/tools/ $*
[Severity: Low]
Should the explicit tools/bootconfig rule earlier in Makefile also pass
QUIET_DESCEND=$(Q)?
Makefile defines a dedicated target for tools/bootconfig that takes
precedence over the generic tools/% pattern rule when building with
CONFIG_CMDLINE_FROM_BOOTCONFIG=y (via prepare: tools/bootconfig) or when
running make tools/bootconfig directly:
Makefile:
tools/bootconfig: export CC := $(HOSTCC)
tools/bootconfig: FORCE
$(Q)mkdir -p $(objtree)/tools
$(Q)$(MAKE) O=$(abspath $(objtree)) subdir=tools -C $(srctree)/tools/ \
bootconfig CROSS_COMPILE=
In tools/Makefile, the bootconfig target uses $(call descend,$@), which
expands $(QUIET_DESCEND):
tools/Makefile:
counter dma firewire hv guest bootconfig spi usb virtio mm bpf iio gpio objtool leds wmi firmware debugging tracing: FORCE
$(call descend,$@)
Without QUIET_DESCEND=$(Q) on the tools/bootconfig recipe, won't Kbuild
still print the DESCEND bootconfig message during builds that invoke
tools/bootconfig?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261102-kbuild-descend-spam-v1-0-caff4f840cb7@weissschuh.net?part=3
next prev parent reply other threads:[~2026-11-03 5:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 3:14 [PATCH 0/3] kbuild: don't print DESCEND messages from tools/ build Thomas Weißschuh
2026-11-02 3:14 ` [PATCH 1/3] tools/build: Deduplicate the descend commands Thomas Weißschuh
2026-11-02 3:14 ` [PATCH 2/3] kbuild: drop the tools/ target Thomas Weißschuh
2026-11-02 3:14 ` [PATCH 3/3] kbuild: don't print DESCEND messages from tools/ build Thomas Weißschuh
2026-11-03 5:56 ` sashiko-bot [this message]
2026-11-06 2:55 ` [PATCH 0/3] " Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-194603@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=nathan@kernel.org \
--cc=nsc@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox