Re: [PATCH v9 11/15] alpha: Remove alpha_ prefix from custom syscall entries

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] alpha: typo __sys__clone3 in syscall.tbl causes undefined symbol
  link failure
--

commit fa967afa6e0adcd94fdda9ada7c1dc69e95fd2a8
Author: André Almeida <andrealmeid@igalia.com>

alpha: Remove alpha_ prefix from custom syscall entries

This commit renames the custom fork, vfork, clone, and clone3 syscall
entry points on Alpha from an alpha_ prefix to a __sys_ prefix in order
to prepare for sharing the common syscall table.

> diff --git a/arch/alpha/kernel/entry.S b/arch/alpha/kernel/entry.S
> index 790389a15c3ce..25d05f45512d2 100644
> --- a/arch/alpha/kernel/entry.S
> +++ b/arch/alpha/kernel/entry.S
> @@ -729,9 +729,9 @@ ret_from_kernel_thread:
>  
>  .macro	fork_like name
>  	.align	4
> -	.globl	alpha_\name
> -	.ent	alpha_\name
> -alpha_\name:
> +	.globl	__sys_\name
> +	.ent	__sys_\name
> +__sys_\name:
>  	.prologue 0
>  	bsr	$1, do_switch_stack
>  	// NB: if anyone adds preemption, this block will need to be protected
> @@ -746,7 +746,7 @@ alpha_\name:
>  	ldq	$26, 56($sp)
>  	lda	$sp, SWITCH_STACK_SIZE($sp)
>  	ret
> -.end	alpha_\name
> +.end	__sys_\name
>  .endm
>  
>  fork_like fork
> diff --git a/arch/alpha/kernel/syscalls/syscall.tbl b/arch/alpha/kernel/syscalls/syscall.tbl
> index 8fc4701a63282..59eb066a40bfc 100644
> --- a/arch/alpha/kernel/syscalls/syscall.tbl
> +++ b/arch/alpha/kernel/syscalls/syscall.tbl

[ ... ]

> @@ -474,7 +474,7 @@
>  542	common	fsmount				sys_fsmount
>  543	common	fspick				sys_fspick
>  544	common	pidfd_open			sys_pidfd_open
> -545	common	clone3				alpha_clone3
> +545	common	clone3				__sys__clone3

[Severity: Low]
As reported by Magnus Lindholm on v7 [1], should this entry in
arch/alpha/kernel/syscalls/syscall.tbl be __sys_clone3 with a single
underscore instead of __sys__clone3?

In arch/alpha/kernel/entry.S, the fork_like macro defines global symbols
with a single underscore after __sys:

    fork_like clone3

which expands to __sys_clone3.

When building an Alpha kernel at this commit, scripts/syscalltbl.sh emits
__SYSCALL(545, __sys__clone3) into asm/syscall_table.h, which
arch/alpha/kernel/systbls.S expands into sys_call_table:

    #define __SYSCALL(nr, entry) .quad entry
            .data
            .align 3
            .globl sys_call_table
    sys_call_table:
    #include <asm/syscall_table.h>

Because __sys__clone3 is not defined anywhere, linking fails with an
undefined reference error. Although the subsequent commit a88b82345eb1
("alpha: Use the common syscall table") replaces this part of
arch/alpha/kernel/syscalls/syscall.tbl with scripts/syscall_common.tbl
and resolves the build error, does this typo break bisectability at this
commit?

[1] https://lore.kernel.org/r/CA+=Fv5Q+sOLmT0Wf3OGdKw=mBt_EoS8ZQDF3wwGrm2-2vnOYgg@mail.gmail.com

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261105-tonyk-syscall_table-v9-0-8d1275885d9c@igalia.com?part=11