Re: [PATCH] Input: apm-power - Rename to apm-power-input

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] Input: apm-power-input - update module name in INPUT_APMPOWER
  Kconfig help
- [Low] Input: apm-power-input - missing Fixes trailer for module name
  conflict
--

commit 8f18f8cadb4c04ceefb13fb63bb9751daa2db15a
Author: Nathan Chancellor <nathan@kernel.org>

> Input: apm-power - Rename to apm-power-input
>
> When scripts/modules-check.sh is fixed to normalize the module's name
> like name-fix-token does in scripts/Makefile.lib before checking that it
> is unique [1], there is an error due to drivers/input/apm-power.ko and
> drivers/power/supply/apm_power.ko having the same module name.
>
>   error: the following would cause module name conflict:
>     drivers/input/apm-power.ko
>     drivers/power/supply/apm_power.ko
>
>   $ modinfo drivers/input/apm-power.ko drivers/power/supply/apm_power.ko | grep name:
>   filename:       drivers/input/apm-power.ko
>   name:           apm_power
>   filename:       drivers/power/supply/apm_power.ko
>   name:           apm_power
>
> Rename drivers/input/apm-power.c to apm-power-input.c to make the module
> name unique and clear up the error.
>
> Reported-by: Sasha Levin <sashal@kernel.org>
> Closes: https://lore.kernel.org/20261108225808.1809266-1-sashal@kernel.org/
> Link: https://lore.kernel.org/20261103110411.11698-1-info@daylightlinux.ch/ [1]
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>

[Severity: Low]
Since drivers/power/supply/apm_power.c already existed when
drivers/input/apm-power.c was added, should this include:

  Fixes: e17bb1de3b7f ("Input: add input event to APM event bridge")

> diff --git a/drivers/input/Makefile b/drivers/input/Makefile
> index 2cd6e1c9a7784..842a7e4f7b508 100644
> --- a/drivers/input/Makefile
> +++ b/drivers/input/Makefile
> @@ -27,6 +27,6 @@ obj-$(CONFIG_INPUT_TOUCHSCREEN)	+= touchscreen/
>  obj-$(CONFIG_INPUT_MISC)	+= misc/
>  obj-$(CONFIG_INPUT_KUNIT_TEST)	+= tests/
>  
> -obj-$(CONFIG_INPUT_APMPOWER)	+= apm-power.o
> +obj-$(CONFIG_INPUT_APMPOWER)	+= apm-power-input.o
>  
>  obj-$(CONFIG_RMI4_CORE)		+= rmi4/

[Severity: Low]
Should the help text for INPUT_APMPOWER in drivers/input/Kconfig also be
updated to say that the module will be called apm-power-input instead of
apm-power?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109-apm-power-input-rename-v1-1-0609e7b91825@kernel.org?part=1