From: sashiko-bot@kernel.org
To: "Nicolas Schier" <nsc@kernel.org>,
"Thomas Weißschuh" <linux@weissschuh.net>,
"Christian Heusel" <christian@heusel.eu>,
"Nathan Chancellor" <nathan@kernel.org>
Cc: linux-kbuild@vger.kernel.org,
"Adrián García Casado" <adriangarciacasado42@gmail.com>
Subject: Re: [PATCH] kbuild: package: Install System.map to build tree only
Date: Tue, 17 Nov 2026 15:53:56 +0000 [thread overview]
Message-ID: <sashiko-outbox-219115@kernel.org> (raw)
In-Reply-To: <20261116-package-install-system-msp-to-build-dir-v1-1-ec53d3d39146@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] kbuild: package: System.map dropped from tar-pkg and dir-pkg
in buildtar
--
commit 4e40237f8938f58bf4db63fc401e165ccfea766e
Author: Nicolas Schier <nsc@kernel.org>
kbuild: package: Install System.map to build tree only
This commit removes the target-specific installation of System.map to
/boot and instead installs System.map into the packaged kernel build tree
via scripts/package/install-extmod-build.
> diff --git a/scripts/package/buildtar b/scripts/package/buildtar
> index cc87a473c01f4..057ca4fc7d71f 100755
> --- a/scripts/package/buildtar
> +++ b/scripts/package/buildtar
> @@ -45,7 +45,6 @@ make ARCH="${ARCH}" -f ${srctree}/Makefile INSTALL_MOD_PATH="${tmpdir}" modules_
> #
> # Install basic kernel files
> #
> -cp -v -- "${objtree}/System.map" "${tmpdir}/boot/System.map-${KERNELRELEASE}"
> cp -v -- "${KCONFIG_CONFIG}" "${tmpdir}/boot/config-${KERNELRELEASE}"
> cp -v -- "${objtree}/vmlinux" "${tmpdir}/boot/vmlinux-${KERNELRELEASE}"
[Severity: Medium]
Does removing this copy drop System.map from the tar-pkg and dir-pkg
targets altogether? Unlike PKGBUILD, builddeb, and kernel.spec, buildtar
does not package a kernel build tree or call
scripts/package/install-extmod-build, so System.map is no longer included
anywhere in the resulting tarball or directory.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-package-install-system-msp-to-build-dir-v1-1-ec53d3d39146@kernel.org?part=1
prev parent reply other threads:[~2026-11-17 15:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 15:52 [PATCH] kbuild: package: Install System.map to build tree only Nicolas Schier
2026-11-17 15:53 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-219115@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=adriangarciacasado42@gmail.com \
--cc=christian@heusel.eu \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=nathan@kernel.org \
--cc=nsc@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox