From: Sascha Silbe <x-linux@infra-silbe.de>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Michal Marek <mmarek@suse.com>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kbuild: add ARM support for tar-pkg
Date: Sun, 14 May 2017 18:54:32 +0200 [thread overview]
Message-ID: <toe37c7bcqf.fsf@twin.sascha.silbe.org> (raw)
In-Reply-To: <CAK7LNASc7NgthfZCWFT=3FhRQxxJuuzDVjT8GHik5A0+zBVxpw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]
Dear Masahiro (is that right?),
Masahiro Yamada <yamada.masahiro@socionext.com> writes:
> 2017-05-13 20:31 GMT+09:00 Sascha Silbe <x-linux@infra-silbe.de>:
>> The fallback code for "unknown" architectures doesn't work on ARM
>> because for ARM (and a couple of other architectures) KBUILD_IMAGE
>> contains only the file name, not the full path. Having an explicit
>> rule also avoids printing the warning for unknown architectures.
>>
>> Signed-off-by: Sascha Silbe <x-linux@infra-silbe.de>
>> ---
>
> Now KBUILD_IMAGE contains the full path for all architectures.
>
>
> Please check the following commit.
>
> commit 152e6744ebfc8fa6cc9fff4ba36271f5f1ba2821
> Author: Michal Marek <mmarek@suse.com>
> Date: Tue Nov 22 22:34:30 2016 +0100
>
> arm: Use full path in KBUILD_IMAGE definition
Figures. I'm sitting on this patch for years and when I finally get
around to write a commit message, somebody fixed it elsewhere and that
patch went in just a few days ago. :)
The second part of the rationale (getting rid of the warning) still
applies, so I'll follow up with a v2.
Sascha
--
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr.: DE281696641
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2017-05-14 16:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-13 11:31 [PATCH] kbuild: add ARM support for tar-pkg Sascha Silbe
2017-05-13 15:22 ` Masahiro Yamada
2017-05-14 16:54 ` Sascha Silbe [this message]
2017-05-14 17:09 ` [PATCH v2] kbuild: add explicit " Sascha Silbe
2017-06-05 9:02 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=toe37c7bcqf.fsf@twin.sascha.silbe.org \
--to=x-linux@infra-silbe.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox