From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f202.google.com ([209.85.215.202]:33815 "EHLO mail-pg1-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725887AbgAFHn1 (ORCPT ); Mon, 6 Jan 2020 02:43:27 -0500 Received: by mail-pg1-f202.google.com with SMTP id t189so33763447pgd.1 for ; Sun, 05 Jan 2020 23:43:27 -0800 (PST) Date: Sun, 05 Jan 2020 23:43:24 -0800 In-Reply-To: <20200104150238.19834-5-masahiroy@kernel.org> Message-Id: Mime-Version: 1.0 References: <20200104150238.19834-1-masahiroy@kernel.org> <20200104150238.19834-5-masahiroy@kernel.org> Subject: Re: [PATCH v2 04/13] initramfs: rename gen_initramfs_list.sh to gen_initramfs.sh From: Greg Thelen Content-Type: text/plain; charset="UTF-8" Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Masahiro Yamada , linux-kbuild@vger.kernel.org Cc: Andrew Morton , Sam Ravnborg , linux-kernel@vger.kernel.org Masahiro Yamada wrote: > The comments in usr/Makefile wrongly refer to the script name (twice). > > Line 37: > # The dependency list is generated by gen_initramfs.sh -l > > Line 54: > # 4) Arguments to gen_initramfs.sh changes > > There does not exist such a script. > > I was going to fix the comments, but after some consideration, I thought > "gen_initramfs.sh" would be more suitable than "gen_initramfs_list.sh" > because it generates an initramfs image in the common usage. > > The script generates a list that can be fed to gen_init_cpio only when > it is directly run without -o or -l option. > > Signed-off-by: Masahiro Yamada > --- > > Changes in v2: None > > usr/Makefile | 2 +- > usr/{gen_initramfs_list.sh => gen_initramfs.sh} | 0 > 2 files changed, 1 insertion(+), 1 deletion(-) > rename usr/{gen_initramfs_list.sh => gen_initramfs.sh} (100%) Will this break klibc? It might have a ref to the old name. https://git.kernel.org/pub/scm/libs/klibc/klibc.git/tree/usr/Kbuild#n55 > diff --git a/usr/Makefile b/usr/Makefile > index 55c942da01cd..e44a66b8c051 100644 > --- a/usr/Makefile > +++ b/usr/Makefile > @@ -24,7 +24,7 @@ $(obj)/initramfs_data.o: $(obj)/$(datafile_y) FORCE > # Generate the initramfs cpio archive > > hostprogs-y := gen_init_cpio > -initramfs := $(CONFIG_SHELL) $(srctree)/$(src)/gen_initramfs_list.sh > +initramfs := $(CONFIG_SHELL) $(srctree)/$(src)/gen_initramfs.sh > ramfs-input := $(if $(filter-out "",$(CONFIG_INITRAMFS_SOURCE)), \ > $(shell echo $(CONFIG_INITRAMFS_SOURCE)),-d) > ramfs-args := \ > diff --git a/usr/gen_initramfs_list.sh b/usr/gen_initramfs.sh > similarity index 100% > rename from usr/gen_initramfs_list.sh > rename to usr/gen_initramfs.sh