From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:40734 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726744AbeHHN3d (ORCPT ); Wed, 8 Aug 2018 09:29:33 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w78B9fdx128318 for ; Wed, 8 Aug 2018 07:10:20 -0400 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0b-001b2d01.pphosted.com with ESMTP id 2kqwpvvfhs-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 08 Aug 2018 07:10:19 -0400 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 8 Aug 2018 12:10:18 +0100 Date: Wed, 8 Aug 2018 13:10:13 +0200 From: Vasily Gorbik Subject: Re: [PATCH 4/4] s390/ftrace: add -mfentry and -mnop-mcount support References: <20180807053017.GA6613@osiris> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180807053017.GA6613@osiris> Message-Id: Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Heiko Carstens Cc: Masahiro Yamada , Michal Marek , Martin Schwidefsky , Steven Rostedt , Ingo Molnar , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, Andi Kleen On Tue, Aug 07, 2018 at 07:30:17AM +0200, Heiko Carstens wrote: > On Mon, Aug 06, 2018 at 03:17:47PM +0200, Vasily Gorbik wrote: > > Utilize -mfentry and -mnop-mcount gcc options together with > > -mrecord-mcount to get compiler generated calls to the profiling functions > > as nops which are compatible with current -mhotpatch=0,3 approach. At the > > same time -mrecord-mcount enables __mcount_loc section generation by > > the compiler which allows to avoid using scripts/recordmcount.pl script. > > > > Signed-off-by: Vasily Gorbik > > --- > > arch/s390/Kconfig | 2 ++ > > arch/s390/Makefile | 16 +++++++++------- > > arch/s390/include/asm/ftrace.h | 6 +++--- > > arch/s390/kernel/ftrace.c | 2 +- > > arch/s390/kernel/mcount.S | 2 +- > > 5 files changed, 16 insertions(+), 12 deletions(-) > > Do you have numbers which tell how much this reduces the compile time of > the kernel on s390? I assume this change makes quite some difference. > Very roughly, best time across several runs. With -j24 on 24 core lpar with -mfentry -mrecord-mcount etc real 0m54.748s user 12m32.041s sys 1m17.778s vs -mhotpatch=0,3 + scripts/recordmcount.pl: real 0m56.752s user 12m52.386s sys 1m35.873s